Avoid forcing int and float type variables in early vtable resolution #10486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a look. I have some plans to rework how trait matching works which would eliminate the idea of early vs late vtable resolution altogether. Might take me a day or two to get to it though. |
|
@nikomatsakis ping |
|
This doesn't seem like the right direction long term but might be reasonable short term. I have to go investigate the code a bit I guess. |
|
Rebased with |
|
needs a rebase |
|
Closing due to inactivity, but feel free to reopen with a rebase! (this sounds like it's a nice improvement!) |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 6, 2023
Mini-fix `double_must_use` for async functions From Rust 1.67 onwards, the `#[must_use]` attribute also applies to the `Future::Output` (rust-lang#100633). So the lint `double_must_use` was linting all async functions. This PR changes the `double_must_use` lint so it ignores `async` functions. --- Closes rust-lang#10486 changelog: [`double_must_use`]: Fix false positive in async function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a request for feedback. This addresses #10436, but I am not sure whether this is the right direction.