Remove SelectionContext::infcx() in favor of field access
#104907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r=me with a rebase and CI/local x.py check being clean |
compiler-errors
force-pushed
the
selcx-infcx
branch
from
c84c61a to
233cf16
Compare
|
@bors r=oli-obk |
|
📌 Commit 233cf165e61f78ac6469da1b5cd9aa81f1491010 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #104902) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
compiler-errors
force-pushed
the
selcx-infcx
branch
from
233cf16 to
6436c34
Compare
|
@bors r=oli-obk |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#104360 (Stabilize native library modifier `verbatim`) - rust-lang#104732 (Refactor `ty::ClosureKind` related stuff) - rust-lang#104795 (Change multiline span ASCII art visual order) - rust-lang#104890 (small method code cleanup) - rust-lang#104907 (Remove `SelectionContext::infcx()` in favor of field access) - rust-lang#104927 (Simplify some binder shifting logic) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulation doesn't seem particularly important here, and having two choices is always more confusing than having one.
r? types