-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #105008
Rollup of 6 pull requests #105008
Conversation
`?0: CoerceUnsized<SomeTy>` can definitely apply because `?0` matches any type, same for `SomeTy: CoerceUnsized<?0>`
…in favour of `TyCtxt::fn_trait_kind_from_def_id`
This is valid per the comment of the `ClosureKind` defition
Stabilize native library modifier `verbatim` Stabilization report - rust-lang#104360 (comment). cc rust-lang#81490 Closes rust-lang#99425
…piler-errors Refactor `ty::ClosureKind` related stuff I've tried to fix all duplication and weirdness, but if I missed something do tell :p r? `@compiler-errors`
Change multiline span ASCII art visual order Tweak the ASCII art for nested multiline spans so that we minimize line overlaps. Partially addresses rust-lang#61017.
small method code cleanup
…-obk Remove `SelectionContext::infcx()` in favor of field access Encapsulation doesn't seem particularly important here, and having two choices is always more confusing than having one. r? types
…gic, r=oli-obk Simplify some binder shifting logic Not sure if worth, but we'll see
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: 69df0f2c2f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (8a09420): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
These perf changes are all noise. @rustbot label: +perf-regression-triaged |
Successful merges:
verbatim
#104360 (Stabilize native library modifierverbatim
)ty::ClosureKind
related stuff #104732 (Refactorty::ClosureKind
related stuff)SelectionContext::infcx()
in favor of field access #104907 (RemoveSelectionContext::infcx()
in favor of field access)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup