rustdoc: remove unnecessary CSS kbd { cursor: default }
#105707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
|
r? @CraftSpider (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
notriddle
force-pushed
the
notriddle/kbd-cursor
branch
from
bc49725
to
9e3d847
Compare
Added along with theme picker changes in e78f139, but no reason seems to have been given at the time for why this particular rule was added. Removing this rule results in `<kbd>` elements getting an I-bar, while the rule causes them to use the "default" arrow, but since selecting the text in these elements works fine, the I-bar is not misleading.
jhpratt
approved these changes
Dec 15, 2022
GuillaumeGomez
approved these changes
Dec 15, 2022
|
Thanks! @bors r=jhpratt,GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 15, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#104592 (Ensure async trait impls are async (or otherwise return an opaque type)) - rust-lang#105623 (Fix `-Z print-type-sizes` for generators with discriminant field ordered first) - rust-lang#105627 (Auto traits in `dyn Trait + Auto` are suggestable) - rust-lang#105633 (Make `report_projection_error` more `Term` agnostic) - rust-lang#105683 (Various cleanups to dest prop) - rust-lang#105692 (Add regression test for rust-lang#104678) - rust-lang#105707 (rustdoc: remove unnecessary CSS `kbd { cursor: default }`) - rust-lang#105715 (Do not mention long types in E0599 label) - rust-lang#105722 (more clippy::complexity fixes) - rust-lang#105724 (rustdoc: remove no-op CSS `.scrape-example .src-line-numbers { margin: 0 }`) - rust-lang#105730 (rustdoc: remove no-op CSS `.item-info:before { color }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added along with theme picker changes in https://github.com/rust-lang/rust/pull/47686/files#diff-7dc22a0530802d77c2f2ec9e834024a5657b6eab4055520fca46edc99a544413R1144, but no reason seems to have been given at the time for why this particular rule was added.
Removing this rule results in
<kbd>elements getting an I-bar, while the rule causes them to use the "default" arrow, but since selecting the text in these elements works fine, the I-bar is not misleading.