Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add long error explanation for error E0472 #105791

Merged
merged 1 commit into from
Dec 21, 2022
Merged

docs: add long error explanation for error E0472 #105791

merged 1 commit into from
Dec 21, 2022

Conversation

Ezrashaw
Copy link
Contributor

Add long-form error docs for E0472: "inline assembly not supported on this target" and update UI tests.

R? @GuillaumeGomez

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 16, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2022

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@Ezrashaw
Copy link
Contributor Author

The current pace is absolutely fine, enjoy your holiday.

The reason I want to assign you is because of #61137, and I intend to finish most of them off.

@Ezrashaw Ezrashaw mentioned this pull request Dec 16, 2022
Merged
@Ezrashaw
Copy link
Contributor Author

Ezrashaw commented Dec 17, 2022 •
edited
Loading

@jruderman Cool, thanks for feedback. While you're at it could you also look at #105792 which is very similar (just a different error code). (merged, don't worry)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#105792 - Ezrashaw:add-e0320-long-docs, r=Gu…
845a012 
…illaumeGomez

docs: add long error explanation for error E0320

Continuation of rust-lang#105791

r? `@GuillaumeGomez`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 17, 2022
@matthiaskrgr
Rollup merge of rust-lang#105792 - Ezrashaw:add-e0320-long-docs, r=Gu…
a8ad7f6 
…illaumeGomez

docs: add long error explanation for error E0320

Continuation of rust-lang#105791

r? ``@GuillaumeGomez``
@Ezrashaw Ezrashaw mentioned this pull request Dec 18, 2022
Merged
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 19, 2022
Closed
100 tasks
@GuillaumeGomez
Copy link
Member

Part of #61137 (if you could link to it if you add other error explanations, it'd be awesome!).

@GuillaumeGomez
Copy link
Member

Thanks to both of you!

@bors r=jruderman,GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Dec 19, 2022

📌 Commit a30dd62b70d7f9b4d6960d8e6f07d23e3d65a453 has been approved by jruderman,GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member

Error in CI.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 19, 2022
@Ezrashaw Ezrashaw force-pushed the add-e0472-long-docs branch 2 times, most recently from 2593fad to b268f10 Compare December 19, 2022 23:06
@Ezrashaw
Copy link
Contributor Author

@GuillaumeGomez Fixed CI error and squashed. Sorry, that shouldn't have happened, was a slight mistake on my part.

@GuillaumeGomez
Copy link
Member

Seems like we're all good. Please ping me once CI pass.

@Ezrashaw
Copy link
Contributor Author

@GuillaumeGomez All done, hopefully I'll get the lists first time next time :P

@GuillaumeGomez
Copy link
Member

If you're not sure about something, you can use the commonmark dingus to check the output.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 20, 2022

📌 Commit 082ca1e has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 20, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 20, 2022
Merged
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Dec 21, 2022
@fee1-dead
Rollup merge of rust-lang#105791 - Ezrashaw:add-e0472-long-docs, r=Gu…
0d92836 
…illaumeGomez

docs: add long error explanation for error E0472

Add long-form error docs for E0472: "inline assembly not supported on this target" and update UI tests.

R? ``@GuillaumeGomez``
@fee1-dead fee1-dead mentioned this pull request Dec 21, 2022
Closed
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Dec 21, 2022
@fee1-dead
Rollup merge of rust-lang#105791 - Ezrashaw:add-e0472-long-docs, r=Gu…
5ba613c 
…illaumeGomez

docs: add long error explanation for error E0472

Add long-form error docs for E0472: "inline assembly not supported on this target" and update UI tests.

R? ```@GuillaumeGomez```
@fee1-dead fee1-dead mentioned this pull request Dec 21, 2022
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2022
@bors
Auto merge of rust-lang#105979 - matthiaskrgr:rollup-2luw3mx, r=matth…
b569c9d 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105791 (docs: add long error explanation for error E0472)
 - rust-lang#105897 (Fix an opaque type ICE)
 - rust-lang#105904 (Fix arch flag on i686-apple-darwin)
 - rust-lang#105949 (Bump `cfg-if` to `1.0` in rustc crates)
 - rust-lang#105964 (rustdoc: prevent CSS layout of line numbers shrinking into nothing)
 - rust-lang#105972 (rustdoc: simplify section anchor CSS)
 - rust-lang#105973 (Avoid going through the happy path in case of non-fn builtin calls)
 - rust-lang#105976 (Remove unused `check-stage2-T-arm-linux-androideabi-H-x86_64-unknown-linux-gnu` make rule)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4726e51 into rust-lang:master Dec 21, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 21, 2022
@Ezrashaw Ezrashaw deleted the add-e0472-long-docs branch December 22, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jruderman jruderman jruderman left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Ezrashaw @rustbot @GuillaumeGomez @bors @rust-log-analyzer @jruderman