-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing long error code explanations #61137
Comments
Can I take one of these on? |
@imbrem: Sure, go ahead! When you open a PR, please link to this issue so others can see what's being worked on. |
Done! Actually, should I have requested/should I request you as a reviewer? |
This is part of the ongoing work for rust-lang#61137
Added error message for E0284 Work on rust-lang#61137
Can I take one of these on too? |
Sure, go ahead (and thanks!). Just like I told previously: don't forget to link to this issue once your PR is open so we can keep track. :) |
…tril Add explanation for E0592 This is a part of #61137 r? @GuillaumeGomez
E0307 handled in #64110. |
Add long error explanation for E0493 Part of rust-lang#61137.
Add long error explanation for E0312 Part of rust-lang#61137.
…524, r=Centril Error explanation e0524 Part of rust-lang#61137
…524, r=Centril Error explanation e0524 Part of rust-lang#61137
I was working on adding an explanation for E0313. But, I hit a roadblock in doing so and I was recommended by other contributors to propose a deprecation for the error code (#103742) since it seemingly isn't emitted anymore by the current revision of the borrow checker and it has no UI tests. Please view the reference issue for more background. |
refactor: merge error code `E0465` into `E0464` `E0465` is an undocumented and untested error code that is functionally identical to `E0464`. This PR merges `E0465` into `E0464`, thus documenting and testing another error code (rust-lang#61137). r? `@GuillaumeGomez` (not sure if you want to review this but it's relevant to my other PRs that you have reviewed)
refactor: merge error code `E0465` into `E0464` `E0465` is an undocumented and untested error code that is functionally identical to `E0464`. This PR merges `E0465` into `E0464`, thus documenting and testing another error code (rust-lang#61137). r? `@GuillaumeGomez` (not sure if you want to review this but it's relevant to my other PRs that you have reviewed)
…errors remove unreachable error code `E0313` Fixes rust-lang#103742 Makes rust-lang#103433 redundant Implements removal of `E0313`. I agree with the linked issue that this error code is unreachable but if someone could confirm that would be great, are crater runs done for this sort of thing? Also removed a redundant `// ignore-tidy-filelength` that I found while reading code. cc `@GuillaumeGomez` rust-lang#61137
…errors remove unreachable error code `E0313` Fixes rust-lang#103742 Makes rust-lang#103433 redundant Implements removal of `E0313`. I agree with the linked issue that this error code is unreachable but if someone could confirm that would be great, are crater runs done for this sort of thing? Also removed a redundant `// ignore-tidy-filelength` that I found while reading code. cc ``@GuillaumeGomez`` rust-lang#61137
remove E0280 After looking at rust-lang#61137 I tried my hand at E0280. I'm unable to find a reasonable example that emits the error. There are a couple of old examples that compile with the current compiler ([rust-lang#26217](rust-lang#26217), [rust-lang#42114](rust-lang#42114), [rust-lang#27113](rust-lang#27113)) and there is a [bug with chalk](https://github.com/rust-lang/rust/blob/b7cdb635c4b973572307ad288466fba64533369c/src/test/ui/chalkify/bugs/async.rs) that makes it emit the error, with a couple more chalk bugs on zulip. It seems like the error is supposed to be emitted from unfulfilled where bounds, of which two are related to borrow checking (error in where T: 'a or where 'a: 'b) and thus tend to emit errors like "lifetime may not live long enough" from borrow checking instead. The final case is with type equality constraints (where <T as Iterator>::Item == u32), which is unimplemented ([rust-lang#20041](rust-lang#20041)). That such different problems are supposed to have the same error code also seems strange to me. Since the error seems to only be emitted when using chalk I propose to remove it and replace it with an ICE instead. A crater run might be warranted. Pinging `@jackh726` due to removal of chalk test that now ICEs.
remove unreachable error code `E0490` AFAIK, the untested and undocumented error code `E0490` is now unreachable, it was from the days of the original borrow checker. cc `@GuillaumeGomez` rust-lang#61137
remove unreachable error code `E0490` AFAIK, the untested and undocumented error code `E0490` is now unreachable, it was from the days of the original borrow checker. cc ``@GuillaumeGomez`` rust-lang#61137
@GuillaumeGomez sigh, turns out that |
It's fine. I'll update the list once the new PR is open. |
…rors document + UI test `E0208` and make its output more user-friendly Cleans up `E0208`'s output a lot. It could actually be useful for someone learning about variance now. I also added a UI test for it in `tests/ui/error-codes/` and wrote some docs for it. r? `@GuillaumeGomez` another error code, can't be bothered to find the issue :P. Obviously there's some compiler stuff, so you'll have to hand it off. Part of rust-lang#61137.
…ption-and-test, r=compiler-errors,GuillaumeGomez Add compiler error E0523 long description and test This PR is one step towards addressing: rust-lang#61137.
…ption-and-test, r=compiler-errors,GuillaumeGomez Add compiler error E0523 long description and test This PR is one step towards addressing: rust-lang#61137.
…r=GuillaumeGomez docs/test: add UI test and docs for `E0476` Final undocumented error code. Not entirely sure about wording in the docs. Part of rust-lang#61137. r? `@compiler-errors` cc `@compiler-errors`
…r=GuillaumeGomez docs/test: add UI test and docs for `E0476` Final undocumented error code. Not entirely sure about wording in the docs. Part of rust-lang#61137. r? ``@compiler-errors`` cc ``@compiler-errors``
…r=GuillaumeGomez docs/test: add UI test and docs for `E0476` Final undocumented error code. Not entirely sure about wording in the docs. Part of rust-lang#61137. r? ```@compiler-errors``` cc ```@compiler-errors```
…e-for-E0311, r=MatthewPeterKelly Add long description and test for E0311 Adds a long description and unit test for the E0311 compiler error. Fixes one line-item in rust-lang/rust#61137.
This is a re-opening of #32777.
Explanations
Those error codes and their explanations are declared in files named
error_codes.rs
. In those files, you can see generally two macros:register_diagnostics
andregister_long_diagnostics
. If an error code is inregister_diagnostics
, it means it lacks long error explanation. The goal of this issue is to add those missing explanations!This is an easy first issue but don't hesitate to ask for help if you're stuck on something!
Here is the list of all error codes that don't have a long error explanation yet:
self
type" instead of "receiver type" #64110)E0313
#106580)E0377
#105935)E0460
andE0457
#105860)E0460
andE0457
#105860)E0461
#106028)E0465
intoE0464
#106282)E0476
#108444)E0490
#106714)E0514
andE0519
#106236)E0514
andE0519
#106236)The text was updated successfully, but these errors were encountered: