Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E0734 and its long explanation #64763

Merged
merged 4 commits into from
Sep 29, 2019

Conversation

GuillaumeGomez
Copy link
Member

Part of #61137

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-25T12:00:06.2748624Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-25T12:00:06.2930042Z ##[command]git config gc.auto 0
2019-09-25T12:00:06.3016422Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-25T12:00:06.3079358Z ##[command]git config --get-all http.proxy
2019-09-25T12:00:06.3224855Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64763/merge:refs/remotes/pull/64763/merge
---
2019-09-25T12:07:32.8981132Z     Finished release [optimized] target(s) in 1m 32s
2019-09-25T12:07:32.9067197Z tidy check
2019-09-25T12:07:33.9818003Z * 579 error codes
2019-09-25T12:07:33.9818743Z * highest error code: E0734
2019-09-25T12:07:34.0806413Z tidy error: /checkout/src/librustc/error_codes.rs:2228: malformed stability attribute: can't parse `since` key
2019-09-25T12:07:35.0307682Z some tidy checks failed
2019-09-25T12:07:35.0313434Z 
2019-09-25T12:07:35.0313434Z 
2019-09-25T12:07:35.0315782Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-09-25T12:07:35.0318958Z 
2019-09-25T12:07:35.0319307Z 
2019-09-25T12:07:35.0333972Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-09-25T12:07:35.0334095Z Build completed unsuccessfully in 0:01:35
2019-09-25T12:07:35.0334095Z Build completed unsuccessfully in 0:01:35
2019-09-25T12:07:35.0385728Z == clock drift check ==
2019-09-25T12:07:35.0407283Z   local time: Wed Sep 25 12:07:35 UTC 2019
2019-09-25T12:07:35.1902227Z   network time: Wed, 25 Sep 2019 12:07:35 GMT
2019-09-25T12:07:35.1906695Z == end clock drift check ==
2019-09-25T12:07:36.5107261Z ##[error]Bash exited with code '1'.
2019-09-25T12:07:36.5138556Z ##[section]Starting: Checkout
2019-09-25T12:07:36.5140368Z ==============================================================================
2019-09-25T12:07:36.5140455Z Task         : Get sources
2019-09-25T12:07:36.5140498Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Copy link
Contributor

@estebank estebank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me after tidy clean up and maybe slight rewording, but leave it to you to decide if it's worth it.

src/librustc/error_codes.rs Outdated Show resolved Hide resolved
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 27, 2019

📌 Commit ecfe92f has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 28, 2019
…-E0734, r=estebank

Add E0734 and its long explanation

Part of rust-lang#61137
bors added a commit that referenced this pull request Sep 28, 2019
Rollup of 6 pull requests

Successful merges:

 - #64455 (Add Long error explanation for E0531)
 - #64546 (Bugfix/rfc 2451 rerebalance tests)
 - #64589 (Differentiate AArch64 bare-metal targets between hf and non-hf.)
 - #64763 (Add E0734 and its long explanation)
 - #64793 (Fix format macro expansions spans to be macro-generated)
 - #64799 (Fix double panic when printing query stack during an ICE)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Sep 28, 2019
…-E0734, r=estebank

Add E0734 and its long explanation

Part of rust-lang#61137
Centril added a commit to Centril/rust that referenced this pull request Sep 28, 2019
…-E0734, r=estebank

Add E0734 and its long explanation

Part of rust-lang#61137
bors added a commit that referenced this pull request Sep 28, 2019
Rollup of 10 pull requests

Successful merges:

 - #64131 (data_structures: Add deterministic FxHashMap and FxHashSet wrappers)
 - #64387 (Fix redundant semicolon lint interaction with proc macro attributes)
 - #64678 (added more context for duplicate lang item errors (fixes #60561))
 - #64763 (Add E0734 and its long explanation)
 - #64793 (Fix format macro expansions spans to be macro-generated)
 - #64837 (Improve wording in documentation of MaybeUninit)
 - #64852 (Print ParamTy span when accessing a field (#52082))
 - #64875 (Upgrade async/await to "used" keywords.)
 - #64876 (Fix typo in intrinsics op safety)
 - #64880 (Slice docs: fix typo)

Failed merges:

r? @ghost
@bors bors merged commit ecfe92f into rust-lang:master Sep 29, 2019
@GuillaumeGomez GuillaumeGomez deleted the long-err-explanation-E0734 branch September 30, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants