Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long error explanation for E0567 #65179

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Add long error explanation for E0567 #65179

merged 2 commits into from
Oct 8, 2019

Conversation

GuillaumeGomez
Copy link
Member

Part of #61137.

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2019
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 7, 2019
Closed
100 tasks
davidtwco
davidtwco requested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one or two minor suggestions. Happy to approve once we've decided if we want to adopt the suggestions.

src/librustc_passes/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_passes/error_codes.rs Outdated Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the long-err-explanation-E0567 branch from 930284a to 59573ec Compare October 7, 2019 15:10
@GuillaumeGomez
Copy link
Member Author

Updated.

davidtwco
davidtwco approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when CI passes

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 7, 2019

📌 Commit 59573eca7d0306432c2035281d0fc9621de9827c has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2019
@Centril Centril mentioned this pull request Oct 8, 2019
Merged
bors added a commit that referenced this pull request Oct 8, 2019
@bors
Auto merge of #65196 - Centril:rollup-q06lcxm, r=Centril
1e1f25e 
Rollup of 8 pull requests

Successful merges:

 - #64726 (rewrite documentation for unimplemented! to clarify use)
 - #65040 (syntax: more cleanups in item and function signature parsing)
 - #65046 (Make `Cell::new` method come first in documentation)
 - #65098 (Add long error explanation for E0561)
 - #65150 (Suggest dereferencing boolean reference when used in 'if' or 'while')
 - #65154 (Fix const generic arguments not displaying in types mismatch diagnostic)
 - #65181 (fix bug in folding for constants)
 - #65187 (use 'invalid argument' for vxWorks)

Failed merges:

 - #65179 (Add long error explanation for E0567)

r? @ghost
@Centril Centril mentioned this pull request Oct 8, 2019
Closed
@bors

This comment has been minimized.

Sign in to view
@bors bors added rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 8, 2019
@GuillaumeGomez GuillaumeGomez force-pushed the long-err-explanation-E0567 branch from 59573ec to 6608e4a Compare October 8, 2019 11:57
@GuillaumeGomez
Copy link
Member Author

Rebased.

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 8, 2019

📌 Commit 6608e4a has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2019
@Centril Centril removed the rollup A PR which is a rollup label Oct 8, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 8, 2019
@Centril
Rollup merge of rust-lang#65179 - GuillaumeGomez:long-err-explanation…
3246ab2 
…-E0567, r=davidtwco

Add long error explanation for E0567

Part of rust-lang#61137.
@Centril Centril mentioned this pull request Oct 8, 2019
Merged
@bors bors added the rollup A PR which is a rollup label Oct 8, 2019
bors added a commit that referenced this pull request Oct 8, 2019
@bors
Auto merge of #65209 - Centril:rollup-tzc0j87, r=Centril
2748a9f 
Rollup of 8 pull requests

Successful merges:

 - #64404 (Add long error explanation for E0495)
 - #64918 (Add long error explanation for E0551)
 - #65102 (Disable stack probe when thread sanitizer is enabled)
 - #65120 (Correctly estimate the required space for string in `StyledBuffer::prepend`)
 - #65145 (When suggesting assoc function with type params, include turbofish)
 - #65162 (Remove loaded_from_cache map from DepGraph)
 - #65176 (Remove query-related macros)
 - #65179 (Add long error explanation for E0567)

Failed merges:

r? @ghost
@bors bors merged commit 6608e4a into rust-lang:master Oct 8, 2019
@Centril Centril removed the rollup A PR which is a rollup label Oct 9, 2019
@GuillaumeGomez GuillaumeGomez deleted the long-err-explanation-E0567 branch October 9, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rust-highfive @davidtwco @bors @Centril