Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long error explanation for E0551 #64918

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Add long error explanation for E0551 #64918

merged 2 commits into from
Oct 8, 2019

Conversation

GuillaumeGomez
Copy link
Member

Part of #61137

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2019
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 30, 2019
Closed
100 tasks
@GuillaumeGomez
Copy link
Member Author

cc @Centril @oli-obk (just pinging people randomly)

@oli-obk
Copy link
Contributor

oli-obk commented Sep 30, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 30, 2019

📌 Commit c9b99a3f9cda8f73d50434dc4cddb28b9f08cc32 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2019
@tmandry tmandry mentioned this pull request Sep 30, 2019
Closed
@tmandry tmandry mentioned this pull request Sep 30, 2019
Merged
bors added a commit that referenced this pull request Oct 1, 2019
@bors
Auto merge of #64932 - tmandry:rollup-7t8x1nz, r=tmandry
42ec683 
Rollup of 9 pull requests

Successful merges:

 - #64377 (Add long error explanation for E0493)
 - #64786 (Use https for curl when building for linux)
 - #64828 (Graphviz debug output for generic dataflow analysis)
 - #64838 (Add long error explanation for E0550)
 - #64891 (Fix `vec![x; n]` with null raw fat pointer zeroing the pointer metadata)
 - #64893 (Zero-initialize `vec![None; n]` for `Option<&T>`, `Option<&mut T>` and `Option<Box<T>>`)
 - #64911 (Fixed a misleading documentation issue #64844)
 - #64921 (Add test for issue-64662)
 - #64923 (Add missing links for mem::needs_drop)

Failed merges:

 - #64918 (Add long error explanation for E0551)

r? @ghost
@bors
Copy link
Contributor

bors commented Oct 1, 2019

☔ The latest upstream changes (presumably #64932) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 1, 2019
@Centril Centril mentioned this pull request Oct 1, 2019
Closed
@GuillaumeGomez GuillaumeGomez force-pushed the long-err-explanation-E0551 branch from c9b99a3 to 62f1fb3 Compare October 1, 2019 13:22
@GuillaumeGomez
Copy link
Member Author

Updated.

@GuillaumeGomez GuillaumeGomez added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 2, 2019
@GuillaumeGomez
Copy link
Member Author

Since I just rebased...

@bors: r=oli-obk

@bors
Copy link
Contributor

bors commented Oct 8, 2019

📌 Commit 62f1fb3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 8, 2019
@Centril
Rollup merge of rust-lang#64918 - GuillaumeGomez:long-err-explanation…
7153c92 
…-E0551, r=oli-obk

Add long error explanation for E0551

Part of rust-lang#61137
@Centril Centril mentioned this pull request Oct 8, 2019
Merged
bors added a commit that referenced this pull request Oct 8, 2019
@bors
Auto merge of #65209 - Centril:rollup-tzc0j87, r=Centril
2748a9f 
Rollup of 8 pull requests

Successful merges:

 - #64404 (Add long error explanation for E0495)
 - #64918 (Add long error explanation for E0551)
 - #65102 (Disable stack probe when thread sanitizer is enabled)
 - #65120 (Correctly estimate the required space for string in `StyledBuffer::prepend`)
 - #65145 (When suggesting assoc function with type params, include turbofish)
 - #65162 (Remove loaded_from_cache map from DepGraph)
 - #65176 (Remove query-related macros)
 - #65179 (Add long error explanation for E0567)

Failed merges:

r? @ghost
@bors bors merged commit 62f1fb3 into rust-lang:master Oct 8, 2019
@GuillaumeGomez GuillaumeGomez deleted the long-err-explanation-E0551 branch October 9, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rust-highfive @oli-obk @bors @eddyb