Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long error explanation for E0493 #64377

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Add long error explanation for E0493 #64377

merged 2 commits into from
Oct 1, 2019

Conversation

GuillaumeGomez
Copy link
Member

Part of #61137.

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2019
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 11, 2019
Closed
100 tasks
Centril
Centril reviewed Sep 11, 2019
View reviewed changes
src/librustc_mir/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_mir/error_codes.rs Outdated Show resolved Hide resolved
src/librustc_mir/error_codes.rs Outdated
// by hand.
```

And by using `lazy_static`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should (only?) suggest lazy_static here. It feels like playing favorites while crates like https://docs.rs/once_cell/1.1.0/once_cell/ might be more idiomatic Rust these days.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should just not talk about those crate at all. I'll remove this part.

@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 12, 2019

📌 Commit 0ad141c has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 13, 2019
@Centril
Rollup merge of rust-lang#64377 - GuillaumeGomez:E0493, r=estebank
1059ddd 
Add long error explanation for E0493

Part of rust-lang#61137.
@Centril Centril mentioned this pull request Sep 13, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Sep 13, 2019

Failed in #64427 (comment), @bors r-

Please run --compare-mode=nll.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2019
@Mark-Simulacrum
Copy link
Member

Awkwardly stealing this PR for some initial testing...

@rust-timer queue

@rust-timer
Copy link
Collaborator

Successfully queued build, kicking off bors: @bors try

@bors
Copy link
Contributor

bors commented Sep 16, 2019

@rust-timer: 🔑 Insufficient privileges: not in try users

@Alexendoo
Copy link
Member

Ping from triage, any updates? @GuillaumeGomez

@Centril
Copy link
Contributor

Centril commented Sep 29, 2019

@GuillaumeGomez updates? // triage

@GuillaumeGomez
Copy link
Member Author

Updated!

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2019

📌 Commit 9f978b7 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 30, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Sep 30, 2019
@tmandry
Rollup merge of rust-lang#64377 - GuillaumeGomez:E0493, r=estebank
30ba6fd 
Add long error explanation for E0493

Part of rust-lang#61137.
@tmandry tmandry mentioned this pull request Sep 30, 2019
Merged
bors added a commit that referenced this pull request Oct 1, 2019
@bors
Auto merge of #64932 - tmandry:rollup-7t8x1nz, r=tmandry
42ec683 
Rollup of 9 pull requests

Successful merges:

 - #64377 (Add long error explanation for E0493)
 - #64786 (Use https for curl when building for linux)
 - #64828 (Graphviz debug output for generic dataflow analysis)
 - #64838 (Add long error explanation for E0550)
 - #64891 (Fix `vec![x; n]` with null raw fat pointer zeroing the pointer metadata)
 - #64893 (Zero-initialize `vec![None; n]` for `Option<&T>`, `Option<&mut T>` and `Option<Box<T>>`)
 - #64911 (Fixed a misleading documentation issue #64844)
 - #64921 (Add test for issue-64662)
 - #64923 (Add missing links for mem::needs_drop)

Failed merges:

 - #64918 (Add long error explanation for E0551)

r? @ghost
@bors bors merged commit 9f978b7 into rust-lang:master Oct 1, 2019
@GuillaumeGomez GuillaumeGomez deleted the E0493 branch October 1, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @rust-highfive @estebank @bors @Centril @Mark-Simulacrum @rust-timer @Alexendoo