Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge error code E0465 into E0464 #106282

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Conversation

Ezrashaw
Copy link
Contributor

E0465 is an undocumented and untested error code that is functionally identical to E0464. This PR merges E0465 into E0464, thus documenting and testing another error code (#61137).

r? @GuillaumeGomez (not sure if you want to review this but it's relevant to my other PRs that you have reviewed)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 30, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 30, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Since you made changes in the compiler, I'll let someone from the compiler team approve this PR.

r? @compiler-errors

@estebank
Copy link
Contributor

r? @estebank @bors r+

@bors
Copy link
Contributor

bors commented Dec 30, 2022

📌 Commit 3bb8903 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2022
jyn514 added a commit to jyn514/rust that referenced this pull request Dec 30, 2022
refactor: merge error code `E0465` into `E0464`

`E0465` is an undocumented and untested error code that is functionally identical to `E0464`. This PR merges `E0465` into `E0464`, thus documenting and testing another error code (rust-lang#61137).

r? `@GuillaumeGomez` (not sure if you want to review this but it's relevant to my other PRs that you have reviewed)
@jyn514
Copy link
Member

jyn514 commented Dec 30, 2022

@bors r-

Failed in rollup: #106306 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 30, 2022
@Ezrashaw
Copy link
Contributor Author

Should all be fixed now, was just a error with the tests.

@jyn514
Copy link
Member

jyn514 commented Dec 31, 2022

@bors r=estebank rollup=iffy

@bors
Copy link
Contributor

bors commented Dec 31, 2022

📌 Commit 24b39ec has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2022
@bors
Copy link
Contributor

bors commented Dec 31, 2022

⌛ Testing commit 24b39ec with merge 574b64a...

@bors
Copy link
Contributor

bors commented Dec 31, 2022

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 574b64a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 31, 2022
@bors bors merged commit 574b64a into rust-lang:master Dec 31, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 31, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (574b64a): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.5% [2.0%, 3.0%] 2
Regressions ❌
(secondary)
2.6% [1.1%, 4.2%] 12
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.5% [2.0%, 3.0%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

@Ezrashaw Ezrashaw deleted the merge-e0465 branch January 1, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants