Error explanation e0524 #64428
Error explanation e0524 #64428
Conversation
|
Some changes occurred in diagnostic error codes |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
src/librustc_mir/error_codes.rs
Outdated
| } | ||
|
|
||
| fn dragoooon(x: &mut isize) { | ||
| { |
There was a problem hiding this comment.
Block not necessary with NLL.
|
r? @Centril |
|
r=me with comments addressed. |
Centril
added
S-waiting-on-author
|
Ping from triage. |
GuillaumeGomez
force-pushed
the
error-explanation-E0524
branch
from
fe76311
to
62ccef4
Compare
|
Updated.
I did, no changes. |
src/librustc_mir/error_codes.rs
Outdated
|
|
||
| To solve this issue, multiple solutions are available. First, is it required | ||
| for this variable to be used in more than one closure at a time? If it is the | ||
| case, use reference countered types such as `Rc` (or `Arc` if it runs |
There was a problem hiding this comment.
| case, use reference countered types such as `Rc` (or `Arc` if it runs | |
| case, use reference counted types such as `Rc` (or `Arc` if it runs |
Oops, looks I just exchanged one typo for another. It's right now at least.
|
@GuillaumeGomez great; left another comment; the unnecessary block should also be removed and then r=me. |
|
@Centril I think the block makes the example simpler to understand (that's why I kept it, forgot to comment about it). |
GuillaumeGomez
force-pushed
the
error-explanation-E0524
branch
from
62ccef4
to
11d88c0
Compare
|
Updated. |
|
@GuillaumeGomez I see; can you add a comment noting that it isn't really necessary? |
|
Sure! |
GuillaumeGomez
force-pushed
the
error-explanation-E0524
branch
from
11d88c0
to
d2b873b
Compare
|
Done! |
|
@bors r+ |
|
📌 Commit d2b873b has been approved by |
bors
added
S-waiting-on-bors
…524, r=Centril Error explanation e0524 Part of rust-lang#61137
…524, r=Centril Error explanation e0524 Part of rust-lang#61137
|
⌛ Testing commit d2b873b with merge efcf6044362591d7b89d89a7fa05bec6aa100569... |
|
@bors retry rolled up. |
|
⌛ Testing commit d2b873b with merge 89471215346eeacf38185f7dc6d9e9df81e2276a... |
|
@bors retry prioritizing stabilization PR. |
…524, r=Centril Error explanation e0524 Part of rust-lang#61137
Rollup of 7 pull requests Successful merges: - #64324 (rustc: Fix mixing crates with different `share_generics`) - #64428 (Error explanation e0524) - #64481 (A more explanatory thread local storage panic message) - #64599 (Rustdoc render async function re-export) - #64743 (Update cargo) - #64746 (Remove blanket silencing of "type annotation needed" errors) - #64753 (Don't emit explain with json short messages.) Failed merges: r? @ghost
Part of #61137