Skip to content

Remove wrapper functions for some unstable options #105955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Noratrieb
Copy link
Member

They are trivial and just forward to the option. Like most other options, we can just access it directly.

They are trivial and just forward to the option. Like most other
options, we can just access it directly.
@Noratrieb Noratrieb marked this pull request as ready for review December 20, 2022 14:03
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2022

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 20, 2022
@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 25, 2022

📌 Commit fb79e44 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 25, 2022
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#105375 (Fix an outdated comment mentioning parameter that doesn't exist anymore)
 - rust-lang#105955 (Remove wrapper functions for some unstable options)
 - rust-lang#106137 (fix more clippy::style findings)
 - rust-lang#106140 (Migrate links-color.goml to functions)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6689d2d into rust-lang:master Dec 26, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 26, 2022
@Noratrieb Noratrieb deleted the no-trivial-opt-wrappers-we-have-field-accesses-for-that branch December 27, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants