fix more clippy::style findings #106137
Merged
fix more clippy::style findings #106137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
match_result_ok obfuscated_if_else single_char_add writeln_empty_string collapsible_match iter_cloned_collect unnecessary_mut_passed
rustbot
added
S-waiting-on-review
jyn514
approved these changes
Dec 25, 2022
| CheckLintNameResult::Tool(result) => { | ||
| if let Err((Some(_), new_name)) = result { | ||
| sess.emit_warning(CheckNameDeprecated { | ||
| lint_name: lint_name.clone(), | ||
| new_name, | ||
| sub: RequestedLevel { level, lint_name }, | ||
| }); | ||
| } | ||
| CheckLintNameResult::Tool(Err((Some(_), new_name))) => { |
There was a problem hiding this comment.
this change looks correct, but for a non-trivial reason, only because the _ => {} branch at the end does nothing
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
leonardo-m
reviewed
Dec 25, 2022
| .copied() | ||
| .collect::<Vec<_>>() | ||
| .join(", "), | ||
| ts[..ts.len() - 1].to_vec().join(", "), |
There was a problem hiding this comment.
It's an example where the Itertools lazy joining is useful... It should be in the stdlib in my opinion.
There was a problem hiding this comment.
This conversation has already been had at length, please don't bring it up on unrelated PRs. #79524
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 25, 2022
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#105375 (Fix an outdated comment mentioning parameter that doesn't exist anymore) - rust-lang#105955 (Remove wrapper functions for some unstable options) - rust-lang#106137 (fix more clippy::style findings) - rust-lang#106140 (Migrate links-color.goml to functions) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
match_result_ok
obfuscated_if_else
single_char_add
writeln_empty_string
collapsible_match
iter_cloned_collect
unnecessary_mut_passed
r? @compiler-errors