Give opaque types a better coherence error #106010
Merged
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TaKO8Ki (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
S-waiting-on-review
| ty::Slice(_) => (this, " because slices are always foreign"), | ||
| ty::Array(..) => (this, " because arrays are always foreign"), | ||
| ty::Tuple(..) => (this, " because tuples are always foreign"), | ||
| let msg = |ty: &str, postfix: &str| { |
There was a problem hiding this comment.
the variable names here are kinda confusing (msg, this, msg), but w/e
|
r? @compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 22, 2022
… r=compiler-errors Give opaque types a better coherence error
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 22, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#104741 (Switch `#[track_caller]` back to a no-op unless feature gate is enabled) - rust-lang#105769 (add function to tell the identical errors for ambiguity_errors) - rust-lang#105843 (Suggest associated const on possible capitalization mistake) - rust-lang#105966 (Re-enable `Fn` trait call notation error for non-tuple argument) - rust-lang#106002 (codegen tests: adapt patterns to also work with v0 symbol mangling) - rust-lang#106010 (Give opaque types a better coherence error) - rust-lang#106016 (rustdoc: simplify link anchor to section expand JS) - rust-lang#106024 (Fix ICE due to `todo!()` in `rustdoc` for `Term`s) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.