Fix ICE due to todo!() in rustdoc for Terms
#106024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @notriddle (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
It would probably be a good idea to add a hot comment testing that the actual output is correct. Some docs on how to do it are buried in https://github.com/rust-lang/rust/blob/master/src/etc/htmldocck.py. |
JulianKnodt
force-pushed
the
add_term_html_docs
branch
from
5ab05be
to
8a4cbf4
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 22, 2022
…notriddle Fix ICE due to `todo!()` in `rustdoc` for `Term`s Left a todo awhile ago (I think), so fill it in to print a const for `Term`s. Fixes rust-lang#105952. Should I add some annotations to the rustdoc test?
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 22, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#104741 (Switch `#[track_caller]` back to a no-op unless feature gate is enabled) - rust-lang#105769 (add function to tell the identical errors for ambiguity_errors) - rust-lang#105843 (Suggest associated const on possible capitalization mistake) - rust-lang#105966 (Re-enable `Fn` trait call notation error for non-tuple argument) - rust-lang#106002 (codegen tests: adapt patterns to also work with v0 symbol mangling) - rust-lang#106010 (Give opaque types a better coherence error) - rust-lang#106016 (rustdoc: simplify link anchor to section expand JS) - rust-lang#106024 (Fix ICE due to `todo!()` in `rustdoc` for `Term`s) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left a todo awhile ago (I think), so fill it in to print a const for
Terms.Fixes #105952.
Should I add some annotations to the rustdoc test?