Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: only use LFS function on glibc #106032

Merged
merged 1 commit into from
Dec 24, 2022
Merged

std: only use LFS function on glibc #106032

merged 1 commit into from
Dec 24, 2022

Conversation

mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Dec 22, 2022

see #94173 and commit 27011b4.

@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 22, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@thomcc
Copy link
Member

thomcc commented Dec 23, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 23, 2022

📌 Commit 3e35b39 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 24, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2022
@bors
Auto merge of rust-lang#106111 - matthiaskrgr:rollup-nnpoe5h, r=matth…
8766bbd 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105465 (Improve top-level docs)
 - rust-lang#105872 (Suggest remove last method call when type coerce with expected  type)
 - rust-lang#106032 (std: only use LFS function on glibc)
 - rust-lang#106078 (Provide more context on FileCheck failures)
 - rust-lang#106100 (Codegen test for derived `<` on trivial newtype [TEST ONLY])
 - rust-lang#106109 (rustdoc: make line number CSS for doc comment and scraped the same)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 74a9b08 into rust-lang:master Dec 24, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 24, 2022
@mochaaP mochaaP deleted the lfs-musl-fix branch December 24, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mochaaP @rustbot @thomcc @bors