Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more context on FileCheck failures #106078

Merged
merged 1 commit into from
Dec 24, 2022

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Dec 23, 2022

FileCheck provides 5 lines of context by default. This is often insufficient to analyze failures that happen in CI. Increase the amount of context to 100 lines.

FileCheck provides 5 lines of context by default. This is often
insufficient to analyze failures that happen in CI. Increase the
amount of context to 100 lines.
@rustbot
Copy link
Collaborator

rustbot commented Dec 23, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 24, 2022

📌 Commit a0b9c5a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 24, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105465 (Improve top-level docs)
 - rust-lang#105872 (Suggest remove last method call when type coerce with expected  type)
 - rust-lang#106032 (std: only use LFS function on glibc)
 - rust-lang#106078 (Provide more context on FileCheck failures)
 - rust-lang#106100 (Codegen test for derived `<` on trivial newtype [TEST ONLY])
 - rust-lang#106109 (rustdoc: make line number CSS for doc comment and scraped the same)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit edb2b71 into rust-lang:master Dec 24, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants