Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean: Remove ctor_kind from VariantStruct. #106356

Merged
merged 1 commit into from
Jan 3, 2023
Merged

clean: Remove ctor_kind from VariantStruct. #106356

merged 1 commit into from
Jan 3, 2023

Conversation

aDotInTheVoid
Copy link
Member

It's always None.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 1, 2023
@aDotInTheVoid
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 1, 2023
@bors
Copy link
Contributor

bors commented Jan 1, 2023

⌛ Trying commit fdef45afc50f926037dba54d5957a4122b968ab4 with merge 02a30d00973da240392d400ee5a3dee4337e6489...

@bors
Copy link
Contributor

bors commented Jan 1, 2023

☀️ Try build successful - checks-actions
Build commit: 02a30d00973da240392d400ee5a3dee4337e6489 (02a30d00973da240392d400ee5a3dee4337e6489)

1 similar comment
@bors
Copy link
Contributor

bors commented Jan 1, 2023

☀️ Try build successful - checks-actions
Build commit: 02a30d00973da240392d400ee5a3dee4337e6489 (02a30d00973da240392d400ee5a3dee4337e6489)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (02a30d00973da240392d400ee5a3dee4337e6489): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 2, 2023
@aDotInTheVoid aDotInTheVoid marked this pull request as ready for review January 2, 2023 23:24
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2023

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

@aDotInTheVoid
Copy link
Member Author

While it doesn't improve perf, it's still worthwhile cleanup.

r? rustdoc

@aDotInTheVoid aDotInTheVoid changed the title [DRAFT] clean: Remove ctor_kind from VariantStruct. clean: Remove ctor_kind from VariantStruct. Jan 2, 2023
@jyn514
Copy link
Member

jyn514 commented Jan 2, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 2, 2023

📌 Commit 0c4bfe4f65deb574eb052903997fceba364f3f47 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2023
@camelid
Copy link
Member

camelid commented Jan 2, 2023

Nice find!

@compiler-errors compiler-errors mentioned this pull request Jan 2, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 3, 2023
@bors
Auto merge of rust-lang#106386 - compiler-errors:rollup-dxjv18b, r=co…
481c9ba 
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#95985 (Add PhantomData marker to Context to make Context !Send and !Sync)
 - rust-lang#104298 (Add notes and examples about non-intuitive `PathBuf::set_extension` behavior)
 - rust-lang#105558 (Reduce HIR debug output)
 - rust-lang#106315 (Cleanup `mingw-tidy` docker job)
 - rust-lang#106354 (Rustdoc-Json: Report discriminant on all kinds of enum variant.)
 - rust-lang#106366 (Fix rustdoc ICE on bad typedef with mismatching types)
 - rust-lang#106376 (Update books)
 - rust-lang#106383 (Document some of the AST nodes)

Failed merges:

 - rust-lang#106356 (clean: Remove `ctor_kind` from `VariantStruct`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Jan 3, 2023

☔ The latest upstream changes (presumably #106386) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 3, 2023
@aDotInTheVoid
Copy link
Member Author

@bors r=jyn514

@bors
Copy link
Contributor

bors commented Jan 3, 2023

📌 Commit f1f99c6 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 3, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 3, 2023
@bors
Auto merge of rust-lang#106409 - matthiaskrgr:rollup-b58z1hz, r=matth…
ab10908 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104552 (warn newer available version of the x tool)
 - rust-lang#105681 (some fixes/improvements to mir::visit module)
 - rust-lang#106005 (Test the borrowck behavior of if-let guards)
 - rust-lang#106356 (clean: Remove `ctor_kind` from `VariantStruct`.)
 - rust-lang#106365 (Grammar : Missing "is" in format specifier diagnostic)
 - rust-lang#106388 (rustdoc: remove legacy box-sizing CSS)
 - rust-lang#106392 (`has_overflow` only if value is *not* within limit)
 - rust-lang#106402 (Fix dupe word typos)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a0458d4 into rust-lang:master Jan 3, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
7 participants
@aDotInTheVoid @rust-timer @bors @rustbot @jyn514 @camelid @notriddle