Fix rustdoc ICE on bad typedef with mismatching types #106366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
GuillaumeGomez
changed the title
|
Oh neat! |
|
Good point! I'll check them out. |
GuillaumeGomez
force-pushed
the
fix-rustdoc-ice-typedef-type-mismatch
branch
from
9b0ea7d
to
d117cbe
Compare
|
Only two issues are still panicking but all the others are fixed by this PR, so it's always that done. :) |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-rustdoc-ice-typedef-type-mismatch
branch
from
d117cbe
to
eadbdff
Compare
|
Q: Why rustdoc even invoked on code, that didn't compile itself and try to fix things by himself? |
This comment has been minimized.
This comment has been minimized.
|
I see at least one answer to that: more evaluations are performed in later rustdoc stages (in the clean pass). Before that, it didn't trigger the error, making |
GuillaumeGomez
force-pushed
the
fix-rustdoc-ice-typedef-type-mismatch
branch
from
eadbdff
to
c156773
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#95985 (Add PhantomData marker to Context to make Context !Send and !Sync) - rust-lang#104298 (Add notes and examples about non-intuitive `PathBuf::set_extension` behavior) - rust-lang#105558 (Reduce HIR debug output) - rust-lang#106315 (Cleanup `mingw-tidy` docker job) - rust-lang#106354 (Rustdoc-Json: Report discriminant on all kinds of enum variant.) - rust-lang#106366 (Fix rustdoc ICE on bad typedef with mismatching types) - rust-lang#106376 (Update books) - rust-lang#106383 (Document some of the AST nodes) Failed merges: - rust-lang#106356 (clean: Remove `ctor_kind` from `VariantStruct`.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106226.
Fixes #105742.
Fixes #105737.
Fixes #105334.
Fixes #96287.
In this case, it's ok to replace the panic with
rustc_error::raisebecause the compiler provided us with aError.r? @notriddle