Skip to content

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jan 2, 2023

Fix #37914.

@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2023

r? @Nilstrieb

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 2, 2023
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach looks good to me modulo a few nits. It probably makes sense for another reviewer to look over it afterwards as I'm not very familiar with this kind of typeck code

@estebank estebank force-pushed the mutability-mismatch-arg branch from 7d7077f to bfffa7c Compare January 5, 2023 07:12
@estebank estebank force-pushed the mutability-mismatch-arg branch from bfffa7c to b693365 Compare January 6, 2023 21:09
@Noratrieb
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 7, 2023

📌 Commit b693365 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 9, 2023
…r=Nilstrieb

Structured suggestion for `&mut dyn Iterator` when possible

Fix rust-lang#37914.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2023
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104163 (Don't derive Debug for `OnceWith` & `RepeatWith`)
 - rust-lang#106131 (Mention "signature" rather than "fn pointer" when impl/trait methods are incompatible)
 - rust-lang#106363 (Structured suggestion for `&mut dyn Iterator` when possible)
 - rust-lang#106497 (Suggest using clone when we have &T and T implemented Clone)
 - rust-lang#106584 (Document that `Vec::from_raw_parts[_in]` must be given a pointer from the correct allocator.)
 - rust-lang#106600 (Suppress type errors that come from private fields)
 - rust-lang#106602 (Add goml scripts to tidy checks)
 - rust-lang#106606 (Do not emit structured suggestion for turbofish with wrong span)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 334426b into rust-lang:master Jan 9, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing compiler error message when attempting to pass a trait object to a function using immutable reference
4 participants