Revert "warn newer available version of the x tool" #106733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
T-bootstrap
jyn514
reviewed
Jan 11, 2023
src/tools/x/src/main.rs
Outdated
Comment on lines
55
to
62
| match env::args().skip(1).next().as_deref() { | ||
| Some("--wrapper-version") => { | ||
| let version = env!("CARGO_PKG_VERSION"); | ||
| println!("{}", version); | ||
| return; | ||
| } | ||
| _ => {} | ||
| } |
There was a problem hiding this comment.
let's keep this so we have fewer people getting warnings when we eventually reland this change.
|
@bors rollup delegate=DebugSteven Please use |
|
✌️ @DebugSteven can now approve this pull request |
bors
added
S-waiting-on-bors
|
@bors r- 😠 |
bors
added
S-waiting-on-author
|
@rustbot label: -S-waiting-on-author +S-waiting-on-review |
rustbot
added
S-waiting-on-review
rustbot
added
S-waiting-on-author
|
@bors r+ |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jan 12, 2023
…er-x, r=jyn514 Revert "warn newer available version of the x tool" Reverts rust-lang#104552 Running the x executable directly created an [issue](rust-lang#106469) here. There are other options for warning a user that a newer version of x exists in the issue's discussion as well. r? ``@jyn514``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2023
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#106167 (Fix invalid syntax and incomplete suggestion in impl Trait parameter type suggestions for E0311) - rust-lang#106309 (Prefer non-`[type error]` candidates during selection) - rust-lang#106532 (Allow codegen to unsize `dyn*` to `dyn`) - rust-lang#106596 (Hide more of long types in E0271) - rust-lang#106638 (std tests: use __OsLocalKeyInner from realstd) - rust-lang#106676 (Test that we cannot use trait impl methods arguments as defining uses) - rust-lang#106702 (Conserve cause of `ImplDerivedObligation` in E0599) - rust-lang#106732 (rustc_llvm: replace llvm::makeArrayRef with ArrayRef constructors.) - rust-lang#106733 (Revert "warn newer available version of the x tool") - rust-lang#106748 (Clean up `OnUnimplementedFormatString::verify`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #104552
Running the x executable directly created an issue here. There are other options for warning a user that a newer version of x exists in the issue's discussion as well.
r? @jyn514