Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #106802

Closed
wants to merge 16 commits into from
Closed

Rollup of 6 pull requests #106802

wants to merge 16 commits into from

Commits on Jan 12, 2023

  1. Provide help on closures capturing self causing borrow checker errors

    @chenyukang
    chenyukang committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    c825459 View commit details
    Browse the repository at this point in the history

  2. take care when there is no args in method call

    @chenyukang
    chenyukang committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    eafbca9 View commit details
    Browse the repository at this point in the history

  3. Point at HIR types when impl trait ref doesn't normalize

    @compiler-errors
    compiler-errors committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d76e168 View commit details
    Browse the repository at this point in the history

  4. Point at impl self type for impl wf obligations

    @compiler-errors
    compiler-errors committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    2aabb0f View commit details
    Browse the repository at this point in the history

  5. Render missing generics suggestion verbosely

    @compiler-errors
    compiler-errors committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    950b47f View commit details
    Browse the repository at this point in the history

  6. Don't suggest dyn as parameter to add

    @compiler-errors
    compiler-errors committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    bf0623e View commit details
    Browse the repository at this point in the history

  7. Only point at impl self ty in WF if trait predicate shares self ty

    @compiler-errors
    compiler-errors committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    5924c25 View commit details
    Browse the repository at this point in the history

  8. Fix ICE formatting

    @estebank
    estebank committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    06a2d2d View commit details
    Browse the repository at this point in the history

  9. is_ty_infer -> is_ty_or_numeric_infer

    @compiler-errors
    compiler-errors committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    8e27211 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Ignore tests move in git blame

    @albertlarsan68
    albertlarsan68 committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    4a3c072 View commit details
    Browse the repository at this point in the history

  2. Rollup merge of rust-lang#106608 - compiler-errors:missing-generics-v… 

    …erbose, r=estebank

Render missing generics suggestion verbosely

It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline.

Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
    @matthiaskrgr
    matthiaskrgr authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    a102fb1 View commit details
    Browse the repository at this point in the history

  3. Rollup merge of rust-lang#106641 - chenyukang:yukang/fix-105761-seggu… 

    …est-this, r=estebank

Provide help on closures capturing self causing borrow checker errors

Fixes rust-lang#105761

r? `@estebank`
    @matthiaskrgr
    matthiaskrgr authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    c06e73f View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#106754 - compiler-errors:ty-infer-method-is… 

    …-confusing, r=lcnr

Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`

Makes sure people are aware that they may have a type variable *or* an int/float variable.

r? ``@oli-obk`` rust-lang#106322 (comment) but I could instead implement your solution, let me know.

(This will conflict with rust-lang#106322 for now, ignore that 😄)
    @matthiaskrgr
    matthiaskrgr authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    dc0ecaa View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#106782 - albertlarsan68:ignore-test-move-in… 

    …-blame, r=Nilstrieb

Ignore tests move in git blame

This commit is not relevant in the history, but may clobber the git blame output.
    @matthiaskrgr
    matthiaskrgr authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    b6f9f55 View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#106785 - compiler-errors:better-impl-wf-spa… 

    …ns, r=estebank

Make blame spans better for impl wfcheck

r? types
    @matthiaskrgr
    matthiaskrgr authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    bfcf0c4 View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#106791 - estebank:fix-ice, r=compiler-errors 

    Fix ICE formatting
    @matthiaskrgr
    matthiaskrgr authored Jan 13, 2023
    Configuration menu
    Copy the full SHA
    df1d6d9 View commit details
    Browse the repository at this point in the history