Don't treat closures from other crates as local #106973
Merged
+58
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
S-waiting-on-review
lcnr
reviewed
Jan 17, 2023
lcnr
reviewed
Jan 19, 2023
oli-obk
force-pushed
the
tait_ice_closure_in_impl_header
branch
from
f8cc286 to
42f1f54
Compare
oli-obk
changed the title
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 20, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#106783 (Recover labels written as identifiers) - rust-lang#106973 (Don't treat closures from other crates as local) - rust-lang#106979 (Document how to get the type of a default associated type) - rust-lang#107053 (signal update string representation for haiku.) - rust-lang#107058 (Recognise double-equals homoglyph) - rust-lang#107067 (Custom MIR: Support storage statements) - rust-lang#107076 (Added const-generic ui test case for issue rust-lang#106419) - rust-lang#107091 (Fix broken format strings in `infer.ftl`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #104817
r? @lcnr
Specialization can prefer an impl for an opaque type over a blanket impls that also matches. If the blanket impl only applies if an auto-trait applies, we look at the hidden type of the opaque type to see if that implements the auto trait. The hidden type can be a closure or generator, and thus we will end up seeing these types in coherence and have to handle them properly.