Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognise double-equals homoglyph #107058

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Recognise double-equals homoglyph #107058

merged 2 commits into from
Jan 20, 2023

Conversation

clubby789
Copy link
Contributor

@clubby789 clubby789 commented Jan 19, 2023 •
edited
Loading

Recognise ⩵ as a homoglyph for ==.

The first commit switches char to &str, as all previous homoglyphs corresponded to a single ASCII character, while the second implements the fix.

@rustbot label +A-diagnostics +A-parser

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-diagnostics Area: Messages for errors, warnings, and lints labels Jan 19, 2023
@clubby789 clubby789 changed the title Eqeq homoglyph Recognise double-equals homoglyph Jan 19, 2023
@rustbot rustbot added the A-parser Area: The parsing of Rust source code to an AST label Jan 19, 2023
@wesleywiser
Copy link
Member

Thanks @clubby789!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 19, 2023

📌 Commit 1487aa9 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2023
@bors
Auto merge of rust-lang#107105 - matthiaskrgr:rollup-rkz9t7r, r=matth…
04a41f8 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#106783 (Recover labels written as identifiers)
 - rust-lang#106973 (Don't treat closures from other crates as local)
 - rust-lang#106979 (Document how to get the type of a default associated type)
 - rust-lang#107053 (signal update string representation for haiku.)
 - rust-lang#107058 (Recognise double-equals homoglyph)
 - rust-lang#107067 (Custom MIR: Support storage statements)
 - rust-lang#107076 (Added const-generic ui test case for issue rust-lang#106419)
 - rust-lang#107091 (Fix broken format strings in `infer.ftl`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3693399 into rust-lang:master Jan 20, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The parsing of Rust source code to an AST S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@clubby789 @rustbot @wesleywiser @bors