Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unsizing_params_for_adt into a query #107146

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Make unsizing_params_for_adt into a query #107146

merged 1 commit into from
Jan 30, 2023

Conversation

compiler-errors
Copy link
Member

Addresses a FIXME in confirmation.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 21, 2023
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 21, 2023
@bors
Copy link
Contributor

bors commented Jan 21, 2023

⌛ Trying commit f6f8f9b886702ef7971a76aba9aabcfccfff3825 with merge 33187f348bff947dd29a929757d000aac626576a...

@bors
Copy link
Contributor

bors commented Jan 21, 2023

☀️ Try build successful - checks-actions
Build commit: 33187f348bff947dd29a929757d000aac626576a (33187f348bff947dd29a929757d000aac626576a)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (33187f348bff947dd29a929757d000aac626576a): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 21, 2023
@compiler-errors
Copy link
Member Author

I'm inclined to land this even if it's perf neutral, since it'll help us share some unsizing code between the old and new trait solvers.

r? compiler

@compiler-errors compiler-errors marked this pull request as ready for review January 21, 2023 17:00
cjgillot
cjgillot reviewed Jan 22, 2023
View reviewed changes
Copy link
Contributor

@cjgillot cjgillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with one nit

compiler/rustc_middle/src/query/mod.rs Outdated Show resolved Hide resolved
@compiler-errors
Copy link
Member Author

@bors r=cjgillot

@bors
Copy link
Contributor

bors commented Jan 22, 2023

📌 Commit e81fe4219477801fedd47cdaf1835181568012ef has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2023
@compiler-errors compiler-errors mentioned this pull request Jan 24, 2023
Merged
@compiler-errors
Copy link
Member Author

This isn't perf sensitive

@bors rollup-

@bors
Copy link
Contributor

bors commented Jan 25, 2023

☔ The latest upstream changes (presumably #103902) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 25, 2023
@compiler-errors
Copy link
Member Author

@bors r=cjgillot

@bors
Copy link
Contributor

bors commented Jan 25, 2023

📌 Commit a89c639 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 25, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jan 27, 2023
@Dylan-DPC
Rollup merge of rust-lang#107146 - compiler-errors:unsizing-params, r…
d1f73fa 
…=cjgillot

Make `unsizing_params_for_adt` into a query

Addresses a FIXME in confirmation.

r? `@ghost`
@Dylan-DPC Dylan-DPC mentioned this pull request Jan 27, 2023
Closed
@bors
Copy link
Contributor

bors commented Jan 28, 2023

☔ The latest upstream changes (presumably #101692) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2023
@compiler-errors
Copy link
Member Author

@bors r=cjgillot

@bors
Copy link
Contributor

bors commented Jan 28, 2023

📌 Commit 32bf8c7 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 28, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 29, 2023
@compiler-errors
Rollup merge of rust-lang#107146 - compiler-errors:unsizing-params, r…
31d103b 
…=cjgillot

Make `unsizing_params_for_adt` into a query

Addresses a FIXME in confirmation.

r? `@ghost`
@compiler-errors compiler-errors mentioned this pull request Jan 29, 2023
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Jan 30, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2023
@bors
Auto merge of rust-lang#107463 - Dylan-DPC:rollup-6mq1li8, r=Dylan-DPC
fba9f33 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#101569 (Don't re-export private/unstable ArgumentV1 from `alloc`.)
 - rust-lang#106106 (Pass `branch.{branch}.remote=origin` to `git submodule update`)
 - rust-lang#107146 (Make `unsizing_params_for_adt` into a query)
 - rust-lang#107264 (Add option to include private items in library docs)
 - rust-lang#107452 (Fix typo in `{Rc, Arc}::get_mut_unchecked` docs)
 - rust-lang#107459 (end entry paragraph with a period (.))

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e19ae97 into rust-lang:master Jan 30, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 30, 2023
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 31, 2023
@JohnTitor
Rollup merge of rust-lang#107245 - compiler-errors:new-solver-unsizin…
6eeb981 
…g, r=lcnr

Implement unsizing in the new trait solver

This makes hello world compile! Ignore the first commit, that's just rust-lang#107146 which is waiting on merge.

I'll leave some comments inline about design choices that might be debatable.

r? `@lcnr` (until we have a new trait solver reviewer group...)
@compiler-errors compiler-errors deleted the unsizing-params branch August 11, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rust-timer @bors @cjgillot @rustbot @Noratrieb