Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unsizing in the new trait solver #107245

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jan 24, 2023

This makes hello world compile! Ignore the first commit, that's just #107146 which is waiting on merge.

I'll leave some comments inline about design choices that might be debatable.

r? @lcnr (until we have a new trait solver reviewer group...)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jan 24, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nits ^^

this impl looks correct but I didn't check that it perfectly matches the existing one. Will just get test failures if there are differences cause I don't think this is unsound.

compiler/rustc_trait_selection/src/solve/trait_goals.rs Outdated Show resolved Hide resolved
compiler/rustc_trait_selection/src/solve/project_goals.rs Outdated Show resolved Hide resolved
compiler/rustc_trait_selection/src/solve/trait_goals.rs Outdated Show resolved Hide resolved
compiler/rustc_ty_utils/src/ty.rs Outdated Show resolved Hide resolved
@compiler-errors
Copy link
Member Author

Waiting on #107146 to land.

@bors
Copy link
Contributor

bors commented Jan 25, 2023

☔ The latest upstream changes (presumably #103902) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jan 26, 2023

☔ The latest upstream changes (presumably #107309) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors
Copy link
Member Author

@bors r=lcnr rollup (only affects new solver)

@bors
Copy link
Contributor

bors commented Jan 30, 2023

📌 Commit 9902ea5dd8e115d56df4ed5b0e923a9c52caa165 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2023
@compiler-errors
Copy link
Member Author

@bors r=lcnr

@bors
Copy link
Contributor

bors commented Jan 30, 2023

📌 Commit f7fc0b7 has been approved by lcnr

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 31, 2023
Rollup of 8 pull requests

Successful merges:

 - rust-lang#107245 (Implement unsizing in the new trait solver)
 - rust-lang#107445 (Remove `GenFuture` from core)
 - rust-lang#107473 (Update books)
 - rust-lang#107476 (rustdoc: remove unnecessary wrapper `div.item-decl` from HTML)
 - rust-lang#107477 (Migrate last part of CSS themes to CSS variables)
 - rust-lang#107479 (Use `ObligationCtxt::new_in_snapshot` in `satisfied_from_param_env`)
 - rust-lang#107482 (rustdoc: remove meta keywords from HTML)
 - rust-lang#107494 (fix link in std::path::Path::display())

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6eeb981 into rust-lang:master Jan 31, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 31, 2023
@compiler-errors compiler-errors deleted the new-solver-unsizing branch August 11, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants