Update Clippy #107386
Merged
Update Clippy #107386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
…ce type is a borrow.
…ion-pedantic, r=Jarcho Move `unchecked_duration_subtraction` to pedantic changelog: [`unchecked_duration_subtraction`]: Move to pedantic Based on https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Meeting.202023-01-10/near/320488860
…, r=davidtwco Add checks for the signature of the `start` lang item Closes rust-lang#105963
…erbose, r=estebank Render missing generics suggestion verbosely It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline. Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
Rollup of 6 pull requests Successful merges: - rust-lang#106608 (Render missing generics suggestion verbosely) - rust-lang#106716 ([RFC 2397] Deny incorrect locations) - rust-lang#106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`) - rust-lang#106782 (Ignore tests move in git blame) - rust-lang#106785 (Make blame spans better for impl wfcheck) - rust-lang#106791 (Fix ICE formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Feed a bunch of queries instead of tracking fields on TyCtxt r? `@cjgillot` pulled out of rust-lang#105462
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
…trait_ref query; add EarlyBinder to impl_trait_ref in metadata
Fix FP in `unnecessary_safety_comment` Fix rust-lang/rust-clippy#10084 changelog: FP: [`unnecessary_safety_comment`]: No longer lints code inside macros [rust-lang#10106](rust-lang/rust-clippy#10106) <!-- changelog_checked -->
use LocalDefId instead of HirId in trait resolution to simplify the obligation clause resolution Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
…s-span, r=giraffate Improve span for module_name_repetitions changelog: [`module_name_repetitions`]: Narrowed span to the identifier
Move format_args!() into AST (and expand it during AST lowering) Implements rust-lang/compiler-team#541 This moves FormatArgs from rustc_builtin_macros to rustc_ast_lowering. For now, the end result is the same. But this allows for future changes to do smarter things with format_args!(). It also allows Clippy to directly access the ast::FormatArgs, making things a lot easier. This change turns the format args types into lang items. The builtin macro used to refer to them by their path. After this change, the path is no longer relevant, making it easier to make changes in `core`. This updates clippy to use the new language items, but this doesn't yet make clippy use the ast::FormatArgs structure that's now available. That should be done after this is merged.
Mark Rust 1.67 as released in the changelog Roses are red, violets are blue, not much to say, not much to do --- changelog: none.
There was a tab after the three leading slashes which caused the contents of the "Why is this bad?" section to be rendered as a code block.
…sed_as_pow, r=Jarcho Fix styling in documentation for `suspicious_xor_used_as_pow` lint There was a tab after the three leading slashes which caused the contents of the "Why is this bad?" section to be rendered as a code block. **Before:** <img width="626" alt="master" src="https://user-images.githubusercontent.com/4869194/214985546-4433d211-9fd3-450c-8ff7-2c0a47fccdc0.png"> **After:** <img width="520" alt="fixed" src="https://user-images.githubusercontent.com/4869194/214985561-87255196-008c-4a1c-8cc8-c54b337d22a2.png"> The file still contains a lot of tabs but they don't affect the documentation. --- changelog: [`suspicious_xor_used_as_pow`]: Fix styling in documentation
Rustup r? `@ghost` changelog: none
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@bors r+ p=1 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (7d4df2d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 10, 2023
Update Clippy r? `@Manishearth`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth