Small bootstrap improvements #107470
Merged
Small bootstrap improvements #107470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Could you please do that in the Rust code too? |
It was already done |
albertlarsan68
changed the title
kadiwa4
commented
Jan 30, 2023
kadiwa4
force-pushed
the
bootstrap_cleanup
branch
2 times, most recently
from
ede90ef
to
a21cc21
Compare
kadiwa4
force-pushed
the
bootstrap_cleanup
branch
from
a21cc21
to
043c634
Compare
|
Thanks for your work! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 1, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#107389 (Fixing confusion between mod and remainder) - rust-lang#107442 (improve panic message for slice windows and chunks) - rust-lang#107470 (Small bootstrap improvements) - rust-lang#107487 (Make the "extra if in let...else block" hint a suggestion) - rust-lang#107499 (Do not depend on Generator trait when deducing closure signature) - rust-lang#107533 (Extend `-Z print-type-sizes` to distinguish generator upvars+locals from "normal" fields.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
jyn514
reviewed
Feb 8, 2023
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 9, 2023
…bertlarsan68 bootstrap.py: fix build-failure message A small mistake I did. Corrects rust-lang#107470, fixes rust-lang#107804 r? `@albertlarsan68` (since you reviewed the last one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xzavailabilitybootstrapmodule even when a package of that name is installed-W semicolon_in_expressions_from_macros– it is warn-by-default--helpflag into the argument parser (makes-hvwork as a short form of--help --verbose)I even checked that it works with Python 2.