Fixing confusion between mod and remainder #107389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
estebank
reviewed
Jan 30, 2023
compiler/rustc_hir_typeck/src/op.rs
Outdated
| @@ -335,7 +335,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| format!("cannot divide `{lhs_ty}` by `{rhs_ty}`") | |||
| } | |||
| hir::BinOpKind::Rem => { | |||
| format!("cannot mod `{lhs_ty}` by `{rhs_ty}`") | |||
| format!("cannot rem `{lhs_ty}` by `{rhs_ty}`") | |||
There was a problem hiding this comment.
Actually, let's expand the wording here to make it even clearer (feel free to change the wording further), here and elsewhere
Suggested change
| format!("cannot rem `{lhs_ty}` by `{rhs_ty}`") | |
| format!("cannot calculate the remainder of `{lhs_ty}` divided by `{rhs_ty}`") |
There was a problem hiding this comment.
Good idea, fixed it.
|
@bors r+ |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 31, 2023
Fixing confusion between mod and remainder Like many programming languages, rust too confuses remainder and modulus. The `%` operator and the associated `Rem` trait is (as the trait name suggests) the remainder, but since most people are linguistically more familiar with the modulus the documentation sometimes claims otherwise. This PR tries to fix this problem in rustc.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 1, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#107389 (Fixing confusion between mod and remainder) - rust-lang#107442 (improve panic message for slice windows and chunks) - rust-lang#107470 (Small bootstrap improvements) - rust-lang#107487 (Make the "extra if in let...else block" hint a suggestion) - rust-lang#107499 (Do not depend on Generator trait when deducing closure signature) - rust-lang#107533 (Extend `-Z print-type-sizes` to distinguish generator upvars+locals from "normal" fields.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like many programming languages, rust too confuses remainder and modulus. The
%operator and the associatedRemtrait is (as the trait name suggests) the remainder, but since most people are linguistically more familiar with the modulus the documentation sometimes claims otherwise. This PR tries to fix this problem in rustc.