Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #107509

Closed
wants to merge 23 commits into from
Closed

Rollup of 7 pull requests #107509

wants to merge 23 commits into from

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tspiteri and others added 23 commits January 27, 2023 12:43
@tspiteri
rustdoc: update Source Serif 4 from 4.004 to 4.005
167fbbc 
Version 4.005 was released on 2023-01-20.
@tspiteri
add comment to rustdoc.css on updating filename suffixes
1c3fc9d
Fixed confusement between mod and remainder
e02517d
@WaffleLapkin
Replace enum ==s with matches where it makes sense
fd649a3
@WaffleLapkin
Use Mutability::{is_mut, is_not}
4d75f61
@WaffleLapkin
Replace some _ == _ || _ == _s with matches!(_, _ | _)s
f1d273c
Improved wording of error messages of missing remainder implementations
8d7b092
Ran rustfmt
af9671f
@edward-shen
Make the "extra if in let...else block" hint a suggestion
e905b93
@compiler-errors
Track bound types like bound regions
0e98a16
@notriddle
rustdoc: remove unused CSS from .setting-check
31c14f6 
These rules were needed for the mobile-style switches, but those
were removed in 0f3ae62
@WaffleLapkin
Review changes
340414e
@WaffleLapkin
Use Edition methods a bit more
fd5774a
@WaffleLapkin
Document rust_2015 methods
5d90413
@WaffleLapkin
Don't do .edition().rust_*()
03158f4
@WaffleLapkin
Don't accept Edition by ref
ef6b583
@GuillaumeGomez
Rollup merge of rust-lang#107354 - tspiteri:source-serif-4.005, r=Gui…
c5092cd 
…llaumeGomez

rustdoc: update Source Serif 4 from 4.004 to 4.005

[Version 4.005](https://github.com/adobe-fonts/source-serif/releases/tag/4.005R) was released on 2023-01-20.
@GuillaumeGomez
Rollup merge of rust-lang#107389 - zvavybir:master, r=estebank
fb3eff2 
Fixing confusion between mod and remainder

Like many programming languages, rust too confuses remainder and modulus.  The `%` operator and the associated `Rem` trait is (as the trait name suggests) the remainder, but since most people are linguistically more familiar with the modulus the documentation sometimes claims otherwise.  This PR tries to fix this problem in rustc.
@GuillaumeGomez
Rollup merge of rust-lang#107467 - WaffleLapkin:uneq, r=oli-obk
037d3e4 
Improve enum checks

Some light refactoring.
@GuillaumeGomez
Rollup merge of rust-lang#107486 - compiler-errors:bound-ty-keep-name…
7e107b3 
…, r=oli-obk

Track bound types like bound regions

When we instantiate bound types into placeholder types, we throw away the names for some reason. These names are particularly useful for error reporting once we have `for<T>` binders.

r? types
@GuillaumeGomez
Rollup merge of rust-lang#107487 - edward-shen:edward-shen/107213-rou…
1e64a38 
…nd-2, r=estebank

Make the "extra if in let...else block" hint a suggestion

Changes the hint to a suggestion, suggested in rust-lang#107213.

r? `@estebank`
@GuillaumeGomez
Rollup merge of rust-lang#107491 - notriddle:notriddle/setting-check,…
a354532 
… r=GuillaumeGomez

rustdoc: remove unused CSS from `.setting-check`

These rules were needed for the mobile-style switches, but those were removed in 0f3ae62
@GuillaumeGomez
Rollup merge of rust-lang#107508 - WaffleLapkin:uneq'15, r=oli-obk
544b73b 
`Edition` micro refactor

r? `@oli-obk`
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 31, 2023
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=7 rollup=never

@bors
Copy link
Contributor

bors commented Jan 31, 2023

📌 Commit 544b73b has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2023
@bors
Copy link
Contributor

bors commented Jan 31, 2023

⌛ Testing commit 544b73b with merge 2bc35e0c57132fb983ecd3633d24ceb594b04175...

@bors
Copy link
Contributor

bors commented Jan 31, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 31, 2023
@GuillaumeGomez
Copy link
Member Author

Seems to be a flaky. Let's retry.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2023
@bors
Copy link
Contributor

bors commented Jan 31, 2023

⌛ Testing commit 544b73b with merge 8012d0cfd41a3553edf90e39b0d6bdebd5705ef6...

@rust-log-analyzer
Copy link
Collaborator

The job armhf-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
---- [ui] tests/ui/rfc-1445-restrict-constants-in-patterns/allow-hide-behind-direct-unsafe-ptr-embedded.rs stdout ----

error: test run failed!
status: exit status: 101
command: RUST_TEST_THREADS="16" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-1445-restrict-constants-in-patterns/allow-hide-behind-direct-unsafe-ptr-embedded/a"
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-1445-restrict-constants-in-patterns/allow-hide-behind-direct-unsafe-ptr-embedded/a", waiting for result
------------------------------------------
--- stderr -------------------------------
thread 'main' panicked at 'client.read_exact(&mut header) failed with Connection reset by peer (os error 104)', src/tools/remote-test-client/src/main.rs:310:9

@GuillaumeGomez
Copy link
Member Author

It's been the same error twice so I don't think it's flaky, I just don't see which PR could be responsible for this error...

@GuillaumeGomez GuillaumeGomez deleted the rollup-miqesvj branch January 31, 2023 19:24
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@GuillaumeGomez @bors @rust-log-analyzer @rustbot @tspiteri @WaffleLapkin @edward-shen @compiler-errors @notriddle