Check for overflow in evaluate_canonical_goal #107739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
spastorino
force-pushed
the
check-overflow-evaluate_canonical_goal
branch
from
30ae0b0 to
f6b0355
Compare
12 tasks
spastorino
changed the title
lcnr
reviewed
Feb 8, 2023
spastorino
force-pushed
the
check-overflow-evaluate_canonical_goal
branch
from
f6b0355 to
74047f4
Compare
|
@lcnr applied the suggested changes, let me know if that was what you had in mind. |
lcnr
reviewed
Feb 10, 2023
spastorino
force-pushed
the
check-overflow-evaluate_canonical_goal
branch
from
74047f4 to
65ccaa5
Compare
spastorino
force-pushed
the
check-overflow-evaluate_canonical_goal
branch
from
65ccaa5 to
fba04cc
Compare
This comment has been minimized.
This comment has been minimized.
spastorino
force-pushed
the
check-overflow-evaluate_canonical_goal
branch
from
fba04cc to
a4c5746
Compare
lcnr
reviewed
Feb 14, 2023
lcnr
reviewed
Feb 14, 2023
spastorino
force-pushed
the
check-overflow-evaluate_canonical_goal
branch
from
a4c5746 to
c8dae10
Compare
spastorino
force-pushed
the
check-overflow-evaluate_canonical_goal
branch
from
bae6e20 to
26136c6
Compare
|
@bors r+ rollup (only new solver) |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
@bors r+ rollup |
|
💡 This pull request was already approved, no need to approve it again.
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 14, 2023
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#103478 ( Suggest fix for misplaced generic params on fn item rust-lang#103366 ) - rust-lang#107739 (Check for overflow in evaluate_canonical_goal) - rust-lang#108003 (Avoid ICE when the generic_span is empty) - rust-lang#108016 ("Basic usage" is redundant for there is just one example) - rust-lang#108023 (Shrink size of array benchmarks) - rust-lang#108024 (add message to update Cargo.toml when x is changed) - rust-lang#108025 (rustdoc: add more tooltips to intra-doc links) - rust-lang#108029 (s/eval_usize/eval_target_usize/ for clarity) - rust-lang#108035 (Avoid using a dead email address as the main email address) - rust-lang#108038 (Remove needless supertrait constraints from Interner projections) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @lcnr