Avoid ICE when the generic_span is empty #108003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
chenyukang
force-pushed
the
yukang/fix-107998
branch
from
e471ae6 to
a86bd6c
Compare
| @@ -2181,6 +2181,11 @@ impl<'a: 'ast, 'ast> LateResolutionVisitor<'a, '_, 'ast> { | |||
| generics_span: Span, | |||
| params: &[ast::GenericParam], | |||
| ) { | |||
| if generics_span.is_empty() { | |||
There was a problem hiding this comment.
Hm... maybe we should put this check into the deletion_span closure instead, and just return None? It's still kind of nice to be able to emit this lint.
There was a problem hiding this comment.
How about we delay the check to this position, so we can emit more possible lint
rust/compiler/rustc_lint/src/context.rs
Line 842 in 5348a89
There was a problem hiding this comment.
That works too probably
chenyukang
force-pushed
the
yukang/fix-107998
branch
from
a86bd6c to
a9e9459
Compare
chenyukang
force-pushed
the
yukang/fix-107998
branch
from
a9e9459 to
3180f1c
Compare
|
@bors r=compiler-errors rollup |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 14, 2023
…mpiler-errors Avoid ICE when the generic_span is empty Fixes rust-lang#107998 r? `@TaKO8Ki`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 14, 2023
…mpiler-errors Avoid ICE when the generic_span is empty Fixes rust-lang#107998 r? ``@TaKO8Ki``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 14, 2023
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#103478 ( Suggest fix for misplaced generic params on fn item rust-lang#103366 ) - rust-lang#107739 (Check for overflow in evaluate_canonical_goal) - rust-lang#108003 (Avoid ICE when the generic_span is empty) - rust-lang#108016 ("Basic usage" is redundant for there is just one example) - rust-lang#108023 (Shrink size of array benchmarks) - rust-lang#108024 (add message to update Cargo.toml when x is changed) - rust-lang#108025 (rustdoc: add more tooltips to intra-doc links) - rust-lang#108029 (s/eval_usize/eval_target_usize/ for clarity) - rust-lang#108035 (Avoid using a dead email address as the main email address) - rust-lang#108038 (Remove needless supertrait constraints from Interner projections) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107998
r? @TaKO8Ki