-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tighter spans for bad inherent impl
self types
#107942
Tighter spans for bad inherent impl
self types
#107942
Conversation
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
tests/ui/error-codes/E0116.stderr
Outdated
| | ||
LL | impl Vec<u8> {} | ||
| ^^^^^^^^^^^^^^^ impl for type defined outside of crate. | ||
| ^^^^^^^ impl for type defined outside of crate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer it if it also pointed at the impl
keyword (impl.start..ty.end
) to emphasize that the impl is wrong and not just something about the type like it being not found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about now
ff7d5ef
to
8570b76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful now, r=me after squashing
8570b76
to
e20f6ff
Compare
@bors r=Nilstrieb rollup |
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107902 (fix: improve the suggestion on future not awaited) - rust-lang#107913 (Update broken link in cargo style guide) - rust-lang#107942 (Tighter spans for bad inherent `impl` self types) - rust-lang#107948 (Allow shortcuts to directories to be used for ./x.py fmt) - rust-lang#107971 (Clearly document intentional UB in mir-opt tests) - rust-lang#107985 (Added another error to be processed in fallback) - rust-lang#108002 (Update books) - rust-lang#108013 (rustdoc: use a string with one-character codes for search index types) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Avoid accessing HIR when it can be avoided Experiment to see if it helps some incremental cases. Will be rebased once rust-lang#107942 gets merged. r? `@ghost`
Avoid accessing HIR when it can be avoided Experiment to see if it helps some incremental cases. Will be rebased once rust-lang/rust#107942 gets merged. r? `@ghost`
Avoid accessing HIR when it can be avoided Experiment to see if it helps some incremental cases. Will be rebased once rust-lang/rust#107942 gets merged. r? `@ghost`
Self-explanatory