Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighter spans for bad inherent impl self types #107942

Merged

Conversation

compiler-errors
Copy link
Member

Self-explanatory

@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2023

r? @Nilstrieb

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 11, 2023
|
LL | impl Vec<u8> {}
| ^^^^^^^^^^^^^^^ impl for type defined outside of crate.
| ^^^^^^^ impl for type defined outside of crate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer it if it also pointed at the impl keyword (impl.start..ty.end) to emphasize that the impl is wrong and not just something about the type like it being not found.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about now

Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful now, r=me after squashing

@compiler-errors
Copy link
Member Author

@bors r=Nilstrieb rollup

@bors
Copy link
Contributor

bors commented Feb 13, 2023

📌 Commit e20f6ff has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107902 (fix: improve the suggestion on future not awaited)
 - rust-lang#107913 (Update broken link in cargo style guide)
 - rust-lang#107942 (Tighter spans for bad inherent `impl` self types)
 - rust-lang#107948 (Allow shortcuts to directories to be used for ./x.py fmt)
 - rust-lang#107971 (Clearly document intentional UB in mir-opt tests)
 - rust-lang#107985 (Added another error to be processed in fallback)
 - rust-lang#108002 (Update books)
 - rust-lang#108013 (rustdoc: use a string with one-character codes for search index types)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5f3d360 into rust-lang:master Feb 14, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 14, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2023
Avoid accessing HIR when it can be avoided

Experiment to see if it helps some incremental cases.

Will be rebased once rust-lang#107942 gets merged.

r? `@ghost`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Feb 16, 2023
Avoid accessing HIR when it can be avoided

Experiment to see if it helps some incremental cases.

Will be rebased once rust-lang/rust#107942 gets merged.

r? `@ghost`
Jarcho pushed a commit to Jarcho/rust-clippy that referenced this pull request Feb 25, 2023
Avoid accessing HIR when it can be avoided

Experiment to see if it helps some incremental cases.

Will be rebased once rust-lang/rust#107942 gets merged.

r? `@ghost`
@compiler-errors compiler-errors deleted the tighter-inherent-impl-bad-spans branch August 11, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants