Clearly document intentional UB in mir-opt tests #107971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
The UB in all of these tests is intentional. Their goal is to test that despite the fact that Miri believes today that these tests have UB, the optimizations we do do not take advantage of that. I'd be happy to mark these tests as "no run" or "intentional Miri UB," but we should not change them. |
|
Yeah. I couldn't figure out what a single one of these tests was testing, which IME is typical of the mir-opt tests. |
JakobDegen
reviewed
Feb 13, 2023
saethlin
changed the title
RalfJung
reviewed
Feb 13, 2023
Yeah I have that problem too. Blessing mir-opt tests can very easily completely destroy what they were intended to test. Cc #85180 |
This comment has been minimized.
This comment has been minimized.
cjgillot
reviewed
Feb 13, 2023
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jakob Degen <jakob.e.degen@gmail.com>
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107902 (fix: improve the suggestion on future not awaited) - rust-lang#107913 (Update broken link in cargo style guide) - rust-lang#107942 (Tighter spans for bad inherent `impl` self types) - rust-lang#107948 (Allow shortcuts to directories to be used for ./x.py fmt) - rust-lang#107971 (Clearly document intentional UB in mir-opt tests) - rust-lang#107985 (Added another error to be processed in fallback) - rust-lang#108002 (Update books) - rust-lang#108013 (rustdoc: use a string with one-character codes for search index types) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the changed mir-opt test input files did not pass Miri. Now they do.
r? @cjgillot because there's a CopyProp test in here that I do not fully understand