-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document tool lints #108912
Document tool lints #108912
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have some bikeshedding but otherwise it looks good
r? Nilstrieb
8acb9b4
to
3abcae2
Compare
@@ -285,6 +302,8 @@ impl EarlyLintPass for LintPassImpl { | |||
} | |||
|
|||
declare_tool_lint! { | |||
/// The `existing_doc_keyword` lint detects use `#[doc()]` keywords | |||
/// that don't exist, e.g. `#[doc(keyword = "..")]`. | |||
pub rustc::EXISTING_DOC_KEYWORD, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont quite understand why this lint exists in the first place, it doesn't seem too useful? #79541 doesn't contain any info
but whatever, not that it matters here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me after CI is happy
@bors delegate+
@bors r+ rollup |
Document tool lints Add brief doc comments for the internal tool lints so a summary can be seen without needing to open source code
Document tool lints Add brief doc comments for the internal tool lints so a summary can be seen without needing to open source code
Document tool lints Add brief doc comments for the internal tool lints so a summary can be seen without needing to open source code
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#105798 (Relax ordering rules for `asm!` operands) - rust-lang#105962 (Stabilize path_as_mut_os_str) - rust-lang#106085 (use problem matchers for tidy CI) - rust-lang#107711 (Stabilize movbe target feature) - rust-lang#108017 (Add `--no-undefined-version` link flag and fix associated breakage) - rust-lang#108891 (Remove an extraneous include) - rust-lang#108902 (no more do while :<) - rust-lang#108912 (Document tool lints) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#105798 (Relax ordering rules for `asm!` operands) - rust-lang#105962 (Stabilize path_as_mut_os_str) - rust-lang#106085 (use problem matchers for tidy CI) - rust-lang#107711 (Stabilize movbe target feature) - rust-lang#108017 (Add `--no-undefined-version` link flag and fix associated breakage) - rust-lang#108891 (Remove an extraneous include) - rust-lang#108902 (no more do while :<) - rust-lang#108912 (Document tool lints) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Add brief doc comments for the internal tool lints so a summary can be seen without needing to open source code