Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc keyword lint pass #79541

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Doc keyword lint pass #79541

merged 3 commits into from
Dec 4, 2020

Conversation

GuillaumeGomez
Copy link
Member

x.py test doesn't seem to work locally for multiple reasons so simpler to just run CI...

@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2020
lcnr
lcnr reviewed Nov 29, 2020
View reviewed changes
compiler/rustc_lint/src/internal.rs Outdated Show resolved Hide resolved
compiler/rustc_lint/src/internal.rs Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the doc-keyword-lint-pass branch 16 times, most recently from d34308b to 3b00fb0 Compare December 1, 2020 10:40
@GuillaumeGomez
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 1, 2020

⌛ Trying commit 3b00fb05050992a7a72fc97b1165c1cbb95de489 with merge 06bd5158a41e9e157607119713430936d68977f6...

@bors
Copy link
Contributor

bors commented Dec 1, 2020

☀️ Try build successful - checks-actions
Build commit: 06bd5158a41e9e157607119713430936d68977f6 (06bd5158a41e9e157607119713430936d68977f6)

@GuillaumeGomez GuillaumeGomez marked this pull request as ready for review December 2, 2020 23:44
@GuillaumeGomez
Copy link
Member Author

This is finally working! \o/ The trick was to run the check on the std lib with stage 2 and not stage 1...

lcnr
lcnr approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for this to src/test/ui-fulldeps?

Doing so should be similar to to https://github.com/rust-lang/rust/blob/master/src/test/ui-fulldeps/internal-lints/qualified_ty_ty_ctxt.rs

implementation lgtm

compiler/rustc_lint/src/internal.rs Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the doc-keyword-lint-pass branch 2 times, most recently from 95fcdc5 to df1e496 Compare December 3, 2020 14:34
lcnr
lcnr approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nits, then r=me

library/std/src/lib.rs Show resolved Hide resolved
compiler/rustc_lint/src/internal.rs Show resolved Hide resolved
@GuillaumeGomez
Copy link
Member Author

Seems like it's ready. Anything else remaining to be done @lcnr ? Thanks for your comments in any case! :)

@lcnr
Copy link
Contributor

lcnr commented Dec 3, 2020

@bors delegate+

@bors
Copy link
Contributor

bors commented Dec 3, 2020

✌️ @GuillaumeGomez can now approve this pull request

@GuillaumeGomez
Copy link
Member Author

@bors: r=lcnr

@bors
Copy link
Contributor

bors commented Dec 3, 2020

📌 Commit 50eb3a8 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2020
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 3, 2020
@GuillaumeGomez
Rollup merge of rust-lang#79541 - GuillaumeGomez:doc-keyword-lint-pas…
fd0634e 
…s, r=lcnr

Doc keyword lint pass

`x.py test` doesn't seem to work locally for multiple reasons so simpler to just run CI...
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 3, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Dec 4, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 4, 2020
@bors
Auto merge of rust-lang#79686 - Dylan-DPC:rollup-leama5f, r=Dylan-DPC
e9dd18c 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#77686 (Render Markdown in search results)
 - rust-lang#79541 (Doc keyword lint pass)
 - rust-lang#79602 (Fix SGX CI)
 - rust-lang#79611 (Use more std:: instead of core:: in docs for consistency)
 - rust-lang#79623 (Pass around Symbols instead of Idents in doctree)
 - rust-lang#79627 (Update cargo)
 - rust-lang#79631 (disable a ptr equality test on Miri)
 - rust-lang#79638 (Use `item_name` instead of pretty printing for resolving `Self` on intra-doc links)
 - rust-lang#79646 (rustc_metadata: Remove some dead code)
 - rust-lang#79664 (move interpret::MemoryKind::Heap to const eval)
 - rust-lang#79678 (Fix some clippy lints)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f406052 into rust-lang:master Dec 4, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 4, 2020
@GuillaumeGomez GuillaumeGomez deleted the doc-keyword-lint-pass branch December 4, 2020 10:17
@jyn514 jyn514 mentioned this pull request Jan 1, 2021
Merged
@Noratrieb Noratrieb mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr approved these changes

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rust-highfive @bors @lcnr @rustbot