fluent_messages macro: don't emit the OS error in a note #109798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to make the normalization of the error message more precise, allowing us to not normalize all notes away.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-translation
|
|
davidtwco
approved these changes
Mar 31, 2023
|
r? @davidtwco |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2023
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#109104 (rustdoc: Fix invalid suggestions on ambiguous intra doc links v2) - rust-lang#109443 (Move `doc(primitive)` future incompat warning to `invalid_doc_attributes`) - rust-lang#109680 (Fix subslice capture in closure) - rust-lang#109798 (fluent_messages macro: don't emit the OS error in a note) - rust-lang#109805 (Source map cleanups) - rust-lang#109818 (rustdoc: Add GUI test for jump to collapsed item) - rust-lang#109820 (rustdoc-search: update docs for comma in `?` help popover) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to make the normalization of the error message precise, allowing us to not normalize all notes away. See #109700 (comment)