Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Add GUI test for jump to collapsed item #109818

Merged
merged 2 commits into from
Mar 31, 2023
Merged

rustdoc: Add GUI test for jump to collapsed item #109818

merged 2 commits into from
Mar 31, 2023

Conversation

GuillaumeGomez
Copy link
Member

Part of #66181.

I updated browser-ui-test version because I needed to add a new command property: GuillaumeGomez/browser-UI-test#452.

r? @notriddle

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 31, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 31, 2023

📌 Commit efad057 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Mar 31, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2023
@bors
Auto merge of rust-lang#109824 - GuillaumeGomez:rollup-i5r4uts, r=Gui…
5e1d329 
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#109104 (rustdoc: Fix invalid suggestions on ambiguous intra doc links v2)
 - rust-lang#109443 (Move `doc(primitive)` future incompat warning to `invalid_doc_attributes`)
 - rust-lang#109680 (Fix subslice capture in closure)
 - rust-lang#109798 (fluent_messages macro: don't emit the OS error in a note)
 - rust-lang#109805 (Source map cleanups)
 - rust-lang#109818 (rustdoc: Add GUI test for jump to collapsed item)
 - rust-lang#109820 (rustdoc-search: update docs for comma in `?` help popover)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 32842e8 into rust-lang:master Mar 31, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 31, 2023
@GuillaumeGomez GuillaumeGomez deleted the test-collapsed-item branch April 1, 2023 08:32
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 6, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#110016 - GuillaumeGomez:gui-collapsed-mobil…
273b221 
…e, r=notriddle

Run collapsed GUI test in mobile mode as well

Extending test from rust-lang#109818 to be run on mobile as well.

Part of rust-lang#66181.

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @notriddle @bors @rustbot