Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #109872

Closed
wants to merge 14 commits into from
Closed

Rollup of 6 pull requests #109872

wants to merge 14 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Kai Luo and others added 14 commits March 23, 2023 17:56
LIBPATH is used as dylib's path environment variable on AIX
35726e9
@lenko-d
check for missing codegen backeng config
88b3ae9
Set LIBPATH
b56fcb1
Use LIBPATH in compiletest
d3cc2f7
@stlankes
Implement read_buf for RustHermit
a9aaf3f 
In principle, this PR extends rust-lang#108326 for RustyHermit.

Signed-off-by: Stefan Lankes <slankes@eonerc.rwth-aachen.de>
@cr1901
Update compiler-builtins to 0.1.91 to bring in msp430 shift primitive…
01f49b3 
… fixes.
@onur-ozkan
Download beta compiler toolchain in bootstrap if it doesn't yet exist
6f8e470 
This is needed for when the shell scripts bypass python altogether and run the downloaded
bootstrap directly. Changes are mainly provided from @jyn514, I just fixed the review notes.

Signed-off-by: ozkanonur <work@onurozkan.dev>
@jyn514
Improve job names in Github Actions preview
423e76f 
Before: `CI / PR (mingw-check, false, ubuntu-20.04-16core-64gb) (pull_request)`
After: `CI / PR - mingw-check (pull_request)`
@matthiaskrgr
Rollup merge of rust-lang#109448 - ozkanonur:download-beta-compiler-t…
a10cd6d 
…oolchain, r=Mark-Simulacrum

Download beta compiler toolchain in bootstrap if it doesn't yet exist

Blocker for rust-lang#107812 and rust-lang#99989

See: rust-lang#107812 (comment)

r? `@jyn514`
@matthiaskrgr
Rollup merge of rust-lang#109526 - bzEq:aix-libpath, r=Mark-Simulacrum
c585811 
LIBPATH is used as dylib's path environment variable on AIX

See https://4js.com/online_documentation/fjs-fgl-3.00.05-manual-html/c_fgl_installation_017.html.
@matthiaskrgr
Rollup merge of rust-lang#109642 - lenko-d:rust_codegen-backends_inte…
e31ca3c 
…racts_confusingly_with_paths, r=Mark-Simulacrum

check for missing codegen backeng config

Fixes [rust-lang#109610](rust-lang#109610)
@matthiaskrgr
Rollup merge of rust-lang#109722 - hermitcore:read, r=Mark-Simulacrum
e79ef4d 
Implement read_buf for RustHermit

In principle, this PR extends rust-lang#108326 for RustyHermit.
@matthiaskrgr
Rollup merge of rust-lang#109756 - cr1901:msp-shift, r=Mark-Simulacrum
a6a60e7 
Update compiler-builtins to 0.1.91 to bring in msp430 shift primitive…

… fixes.

This fixes unsoundness on MSP430 where `compiler-builtins` and LLVM didn't agree on the width of the shift amount argument of the shifting primitives (4 bytes vs 2 bytes). See rust-lang/compiler-builtins#522 for more details.
@matthiaskrgr
Rollup merge of rust-lang#109868 - jyn514:ci-names, r=Mark-Simulacrum
6e22353 
Improve PR job names in Github Actions preview

Fixes https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/PR.20CI.20job.20names.

Before: `CI / PR (mingw-check, false, ubuntu-20.04-16core-64gb) (pull_request)`
After:  `CI / PR - mingw-check (pull_request)`

r? `@jyn514`
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 2, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Apr 2, 2023

📌 Commit 6e22353 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2023
@bors
Copy link
Contributor

bors commented Apr 3, 2023

⌛ Testing commit 6e22353 with merge ca33501f76cf65cb05250b53580069d6d0183213...

@bors
Copy link
Contributor

bors commented Apr 3, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 3, 2023
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
test setup::tests::check_matching_settings_hash ... ok

failures:

---- builder::tests::alias_and_path_for_library stdout ----
thread 'builder::tests::alias_and_path_for_library' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17

---- builder::tests::defaults::build_cross_compile stdout ----
---- builder::tests::defaults::build_cross_compile stdout ----
thread 'builder::tests::defaults::build_cross_compile' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::defaults::build_default stdout ----
---- builder::tests::defaults::build_default stdout ----
thread 'builder::tests::defaults::build_default' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::defaults::build_stage_0 stdout ----
---- builder::tests::defaults::build_stage_0 stdout ----
thread 'builder::tests::defaults::build_stage_0' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::defaults::doc_default stdout ----
---- builder::tests::defaults::doc_default stdout ----
thread 'builder::tests::defaults::doc_default' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::build_all stdout ----
---- builder::tests::dist::build_all stdout ----
thread 'builder::tests::dist::build_all' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::build_with_empty_host stdout ----
---- builder::tests::dist::build_with_empty_host stdout ----
thread 'builder::tests::dist::build_with_empty_host' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::dist_baseline stdout ----
---- builder::tests::dist::dist_baseline stdout ----
thread 'builder::tests::dist::dist_baseline' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::dist_only_cross_host stdout ----
---- builder::tests::dist::dist_only_cross_host stdout ----
thread 'builder::tests::dist::dist_only_cross_host' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::dist_with_empty_host stdout ----
---- builder::tests::dist::dist_with_empty_host stdout ----
thread 'builder::tests::dist::dist_with_empty_host' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::dist_with_hosts stdout ----
---- builder::tests::dist::dist_with_hosts stdout ----
thread 'builder::tests::dist::dist_with_hosts' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::dist_with_same_targets_and_hosts stdout ----
---- builder::tests::dist::dist_with_same_targets_and_hosts stdout ----
thread 'builder::tests::dist::dist_with_same_targets_and_hosts' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::dist_with_targets stdout ----
---- builder::tests::dist::dist_with_targets stdout ----
thread 'builder::tests::dist::dist_with_targets' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::dist_with_targets_and_hosts stdout ----
---- builder::tests::dist::dist_with_targets_and_hosts stdout ----
thread 'builder::tests::dist::dist_with_targets_and_hosts' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::doc_ci stdout ----
---- builder::tests::dist::doc_ci stdout ----
thread 'builder::tests::dist::doc_ci' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::test_docs stdout ----
---- builder::tests::dist::test_docs stdout ----
thread 'builder::tests::dist::test_docs' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::dist::test_with_no_doc_stage0 stdout ----
---- builder::tests::dist::test_with_no_doc_stage0 stdout ----
thread 'builder::tests::dist::test_with_no_doc_stage0' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::test_exclude stdout ----
---- builder::tests::test_exclude stdout ----
thread 'builder::tests::test_exclude' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::test_exclude_kind stdout ----
---- builder::tests::test_exclude_kind stdout ----
thread 'builder::tests::test_exclude_kind' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- builder::tests::test_valid stdout ----
---- builder::tests::test_valid stdout ----
thread 'builder::tests::test_valid' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- config::tests::detect_src_and_out stdout ----
---- config::tests::detect_src_and_out stdout ----
thread 'config::tests::detect_src_and_out' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17
---- config::tests::download_ci_llvm stdout ----
---- config::tests::download_ci_llvm stdout ----
thread 'config::tests::download_ci_llvm' panicked at 'fs::remove_dir_all(&bin_root) failed with Access is denied. (os error 5)', download.rs:422:17

failures:
    builder::tests::alias_and_path_for_library
    builder::tests::defaults::build_cross_compile
---
test result: FAILED. 3 passed; 22 failed; 0 ignored; 0 measured; 0 filtered out; finished in 694.63ms

error: test failed, to rerun pass `--lib`
Build completed unsuccessfully in 1:10:32
make: *** [Makefile:68: ci-subset-1] Error 1

@ehuss ehuss mentioned this pull request Apr 3, 2023
Merged
@ehuss
Copy link
Contributor

ehuss commented Apr 3, 2023

Failure was #109448.

@matthiaskrgr matthiaskrgr deleted the rollup-5kjxfxn branch March 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@matthiaskrgr @bors @rust-log-analyzer @ehuss @rustbot @lenko-d @stlankes @cr1901 @onur-ozkan @jyn514