-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use apple-m1 as target CPU for aarch64-apple-darwin. #109899
Conversation
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
FWIW, the minimum is now LLVM 14: #107573 |
r? compiler |
@rustbot ping macos What do you all think about changing |
Hey MacOS Group! This issue or PR could use some MacOS-specific guidance. Could one |
Hmm, weren't there dev kits where this was not the case? I'm not sure we care about that, though. |
Ah, apparently the devkits used https://en.wikipedia.org/wiki/Apple_A12X, so A14 wouldn't work on them anyway. I'm not opposed then (not that I think dev kits are a reason to stop this change -- They can always use |
( |
Ah, well, you'll need |
@thomcc the M1 devkits needed to be returned to Apple. So we can assume they aren't being used in the wild. |
What does clang use for this? I think we usually try to align with them, which (I've heard) simplifies cross-lang LTO. |
It also uses apple-m1: https://github.com/llvm/llvm-project/blob/0e85260db1cfd4e8688d917a09a212c2d9a343f3/clang/lib/Driver/ToolChains/Arch/AArch64.cpp#L50-L54 |
It's hard to argue against switching in that case. Sounds good to me. |
Seems like from the comments this is appropriate @bors r+ rollup |
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#95198 (Add slice::{split_,}{first,last}_chunk{,_mut}) - rust-lang#109899 (Use apple-m1 as target CPU for aarch64-apple-darwin.) - rust-lang#111624 (Emit diagnostic for privately uninhabited uncovered witnesses.) - rust-lang#111875 (Don't leak the function that is called on drop) r? `@ghost` `@rustbot` modify labels: rollup
This updates the target CPU for the
aarch64-apple-darwin
target toapple-m1
, which is the first generation of CPUs with this target anyway.This wasn't able to be done before because of the minimum supported version of LLVM being 12, now that it was updated to 13 (in fact we are already at 14), this is available.
See previous update: #90478.
See LLVM update: #100460.