-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use apple-a14 as target CPU for aarch64-apple-darwin #90478
Conversation
After updating the minimum required LLVM version to 12 we can use apple-a14 as that is closer in features to the Apple M1 than the A12. Once the minimum required LLVM version is updated to 13 we can use apple-m1.
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me since A14 and M1 use the same ARM revision and the M1 was the first generation of aarch64-apple-darwin
devices.
@bors r+ |
📌 Commit 3747628 has been approved by |
Use apple-a14 as target CPU for aarch64-apple-darwin After updating the minimum required LLVM version to 12 (rust-lang#90175) we can use `apple-a14` as target CPU, because that CPU is similar in features to the Apple M1 (see [LLVM 13 source](https://github.com/llvm/llvm-project/blob/b8016b626ec7095c7d57ebfffb2135dc5c3077b8/llvm/lib/Target/AArch64/AArch64.td#L1127)). Once the minimum required LLVM version is updated to 13 we can use `apple-m1` here.
Use apple-a14 as target CPU for aarch64-apple-darwin After updating the minimum required LLVM version to 12 (rust-lang#90175) we can use `apple-a14` as target CPU, because that CPU is similar in features to the Apple M1 (see [LLVM 13 source](https://github.com/llvm/llvm-project/blob/b8016b626ec7095c7d57ebfffb2135dc5c3077b8/llvm/lib/Target/AArch64/AArch64.td#L1127)). Once the minimum required LLVM version is updated to 13 we can use `apple-m1` here.
Use apple-a14 as target CPU for aarch64-apple-darwin After updating the minimum required LLVM version to 12 (rust-lang#90175) we can use `apple-a14` as target CPU, because that CPU is similar in features to the Apple M1 (see [LLVM 13 source](https://github.com/llvm/llvm-project/blob/b8016b626ec7095c7d57ebfffb2135dc5c3077b8/llvm/lib/Target/AArch64/AArch64.td#L1127)). Once the minimum required LLVM version is updated to 13 we can use `apple-m1` here.
Use apple-a14 as target CPU for aarch64-apple-darwin After updating the minimum required LLVM version to 12 (rust-lang#90175) we can use `apple-a14` as target CPU, because that CPU is similar in features to the Apple M1 (see [LLVM 13 source](https://github.com/llvm/llvm-project/blob/b8016b626ec7095c7d57ebfffb2135dc5c3077b8/llvm/lib/Target/AArch64/AArch64.td#L1127)). Once the minimum required LLVM version is updated to 13 we can use `apple-m1` here.
☀️ Test successful - checks-actions |
Finished benchmarking commit (3831aaa): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Use apple-m1 as target CPU for aarch64-apple-darwin. This updates the target CPU for the `aarch64-apple-darwin` target to `apple-m1`, which is the first generation of CPUs with this target anyway. This wasn't able to be done before because of the minimum supported version of LLVM being 12, now that it was updated to 13 (in fact we are already at 14), this is available. See previous update: rust-lang#90478. See LLVM update: rust-lang#100460.
After updating the minimum required LLVM version to 12 (#90175) we can use
apple-a14
as target CPU, because that CPU is similar in features to the Apple M1 (see LLVM 13 source). Once the minimum required LLVM version is updated to 13 we can useapple-m1
here.