compiletest: Use remap-path-prefix only in CI #110115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes jump-to-definition work in most IDEs, as well as being easier to understand for contributors.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
compiler-errors
approved these changes
Apr 9, 2023
|
@bors r=compiler-errors rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#109724 (prioritize param env candidates if they don't guide type inference) - rust-lang#110021 (Fix a couple ICEs in the new `CastKind::Transmute` code) - rust-lang#110044 (Avoid some manual slice length calculation) - rust-lang#110115 (compiletest: Use remap-path-prefix only in CI) - rust-lang#110121 (Fix `x check --stage 1` when download-rustc is enabled) - rust-lang#110124 (Some clippy fixes in the compiler) Failed merges: - rust-lang#109752 (Stall auto trait assembly in new solver for int/float vars) r? `@ghost` `@rustbot` modify labels: rollup
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 2, 2023
With rust-lang/rust#110115, some path length reduction features are only enabled on CI. We fake that with GITHUB_ACTIONS=true. Bug: 1441182 Change-Id: I09dc11459f1a0d941846075b52ada717ef0e2a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4496591 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#1138102}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes jump-to-definition work in most IDEs, as well as being easier to understand for contributors.
Fixes #109725. cc @TimNN