Rollup of 6 pull requests #110137
Merged
Rollup of 6 pull requests #110137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for us to write the multiplication when `size_of_val` does exactly what we need.
This makes jump-to-definition work in most IDEs, as well as being easier to understand for contributors.
This pattern is fine for arena allocators.
Nothing was really incorrect before, but it did get nicer.
The shadowing lead to an incorrect comparison. Rename it and compare it properly. compiler-errors told me that I should just include the fix here without a test.
Exhaustively destructure and ignore `()`
Co-authored-by: Michael Goulet <michael@errs.io>
…rors prioritize param env candidates if they don't guide type inference intended to supersede rust-lang#109579. We disable the prioritization during coherence to maintain completeness. Long term we can hopefully replace this hack with adding OR to external constraints at which point the only relevant part when merging responses is whether they guide type inference in the same way. Reuses `try_merge_responses` for assembly and the cleanest way to impl that was to actually split that so that `try_merge_responses` returns `None` if we fail to merge them and then add `flounder` which is used afterwards which is allowed to lower the certainty of our responses. If, in the future, we add the ability to merge candidates `YES: ?0 = Vec<u32>` and `YES: ?0 = Vec<i32>` to `AMBIG: ?0 = Vec<?1>`, this should happen in `flounder`. r? `@compiler-errors` `@BoxyUwU`
…rors Fix a couple ICEs in the new `CastKind::Transmute` code Check the sizes of the immediates, rather than the overall types, when deciding whether we can convert types without going through memory. Fixes rust-lang#110005 Fixes rust-lang#109992 Fixes rust-lang#110032 cc `@matthiaskrgr`
…Denton Avoid some manual slice length calculation No need for us to write the multiplication when `size_of_val` does exactly what we need. (rust-lang/rust-clippy#10601)
…piler-errors compiletest: Use remap-path-prefix only in CI This makes jump-to-definition work in most IDEs, as well as being easier to understand for contributors. Fixes rust-lang#109725. cc `@TimNN`
Fix `x check --stage 1` when download-rustc is enabled Helps with rust-lang#81930
…-errors Some clippy fixes in the compiler Best reviewed commit-by-commit 📎.
rustbot
added
A-testsuite
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
@bors r+ rollup=never p=5 |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 7f7e8fbc99 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 10, 2023
|
Finished benchmarking commit (d4be8ef): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
CastKind::Transmutecode #110021 (Fix a couple ICEs in the newCastKind::Transmutecode)x check --stage 1when download-rustc is enabled #110121 (Fixx check --stage 1when download-rustc is enabled)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup