Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renumbering cleanups #110176

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Renumbering cleanups #110176

merged 3 commits into from
Apr 12, 2023

Conversation

nnethercote
Copy link
Contributor

r? @lqd

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 11, 2023
@nnethercote
Copy link
Contributor Author

@bors rollup=always

@lqd
Copy link
Member

lqd commented Apr 11, 2023

Sure why not, alternatively we could remove the trivial helper method instead.

It's pre-existing but we probably could also improve the name NLLVisitor to the thing it is doing, like RegionRenumber or similar.

r=me either way

@nnethercote
Rename NllVisitor as RegionRenumberer.
7446321 
It's a more descriptive name.
@nnethercote
Copy link
Contributor Author

I renamed NllVisitor as RegionRenumberer.

@bors r=lqd

@bors
Copy link
Contributor

bors commented Apr 11, 2023

📌 Commit 7446321 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 12, 2023
@compiler-errors
Rollup merge of rust-lang#110176 - nnethercote:renumber-cleanups, r=lqd
70f73f0 
Renumbering cleanups

r? `@lqd`
@compiler-errors compiler-errors mentioned this pull request Apr 12, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2023
@bors
Auto merge of rust-lang#110239 - matthiaskrgr:rollup-o90hx4s, r=matth…
59a05ad 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#109959 (Fix transmute intrinsic mir validation ICE)
 - rust-lang#110176 (Renumbering cleanups)
 - rust-lang#110182 (Use `itertools::Either` instead of own impl)
 - rust-lang#110188 (Remove orphaned remove_dir_all implementation from rust-installer)
 - rust-lang#110190 (Custom MIR: Support `BinOp::Offset`)
 - rust-lang#110209 (Add regression test for rust-lang#59003)
 - rust-lang#110210 (`DescriptionCtx` cleanups)
 - rust-lang#110217 (doc: loongarch: Fix typos)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 827b74c into rust-lang:master Apr 12, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 12, 2023
@nnethercote nnethercote deleted the renumber-cleanups branch April 12, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lqd lqd

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nnethercote @lqd @bors @rustbot