-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove orphaned remove_dir_all implementation from rust-installer #110188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea why it's here, but it's not used at all.
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Apr 11, 2023
Noratrieb
force-pushed
the
remove-remove-dir-all
branch
from
April 11, 2023 12:33
0ac3173
to
a11053a
Compare
These commits modify the If this was intentional then you can ignore this comment. |
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 11, 2023
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 11, 2023
…=jyn514 Remove orphaned remove_dir_all implementation from rust-installer I have no idea why it's here, but it's not used at all. r? Mark-Simulacrum
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 12, 2023
…=jyn514 Remove orphaned remove_dir_all implementation from rust-installer I have no idea why it's here, but it's not used at all. r? Mark-Simulacrum
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#109959 (Fix transmute intrinsic mir validation ICE) - rust-lang#110176 (Renumbering cleanups) - rust-lang#110182 (Use `itertools::Either` instead of own impl) - rust-lang#110188 (Remove orphaned remove_dir_all implementation from rust-installer) - rust-lang#110190 (Custom MIR: Support `BinOp::Offset`) - rust-lang#110209 (Add regression test for rust-lang#59003) - rust-lang#110210 (`DescriptionCtx` cleanups) - rust-lang#110217 (doc: loongarch: Fix typos) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why it's here, but it's not used at all.
r? Mark-Simulacrum