Ping Nadrieril when changing exhaustiveness checking #111033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-meta
|
Yeah, it's totally reasonable as a contributor to just add yourself if you'd like to get pinged on some important piece of code. @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 1, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110823 (Tweak await span to not contain dot) - rust-lang#111015 (Remove wrong assertion in match checking.) - rust-lang#111023 (Test precise capture with a multi-variant enum and exhaustive patterns) - rust-lang#111032 (Migrate `builtin_macros::asm` diagnostics to translatable diagnostics) - rust-lang#111033 (Ping Nadrieril when changing exhaustiveness checking) - rust-lang#111037 (Close parentheses for `offset_of` in AST pretty printing) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I don't know what the procedure is but I'd quite like to be pinged when people try to change the exhaustiveness code. It's a tricky piece of code and I'm the de facto expert on it; I'd like to be available to provide feedback to contributors who wish to change it. I occasionally look through the git history and open PRs but a triagebot ping would be much more convenient.
The message says "might have" because
check_match.rscontains a little bit of exhaustiveness logic and a lot of other match-related checks, so this ping will have false positives.