Rollup of 6 pull requests #111040
Merged
Rollup of 6 pull requests #111040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test checking that it is possible to capture fields of a multi-variant enum, when remaining variants are visibly uninhabited (under the `exhaustive_patterns` feature gate).
HIR pretty printing already handles it correctly.
…r=b-naber Tweak await span to not contain dot Fixes a discrepancy between method calls and await expressions where the latter are desugared to have a span that *contains* the dot (i.e. `.await`) but method call identifiers don't contain the dot. This leads to weird suggestions suggestions in borrowck -- see linked issue. Fixes rust-lang#110761 This mostly touches a bunch of tests to tighten their `await` span.
…er-errors Remove wrong assertion in match checking. This assertions is completely misguided, introduced by rust-lang#108504. The responsible PR is on beta, nominating for backport. Instead of checking that this is not a `&&`, it would make sense to check that neither arms of that `&&` is a `let`. This seems like a lot of code for unclear benefit. r? `@saethlin`
…ompiler-errors Test precise capture with a multi-variant enum and exhaustive patterns Add test checking that it is possible to capture fields of a multi-variant enum, when remaining variants are visibly uninhabited (under the `exhaustive_patterns` feature gate).
… r=compiler-errors Migrate `builtin_macros::asm` diagnostics to translatable diagnostics cc rust-lang#100717 Planning on working through the remaining diagnostics in this crate
…ompiler-errors Ping Nadrieril when changing exhaustiveness checking Hi! I don't know what the procedure is but I'd quite like to be pinged when people try to change the exhaustiveness code. It's a tricky piece of code and I'm the de facto expert on it; I'd like to be available to provide feedback to contributors who wish to change it. I occasionally look through the git history and open PRs but a triagebot ping would be much more convenient. The message says "might have" because `check_match.rs` contains a little bit of exhaustiveness logic and a lot of other match-related checks, so this ping will have false positives.
…mpiler-errors Close parentheses for `offset_of` in AST pretty printing HIR pretty printing already handles it correctly. This will conflict with rust-lang#110694 but it seems like that PR is gonna take bit more time.
rustbot
added
A-meta
|
@bors r+ rollup=never p=6 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 9ecda8de85 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced May 1, 2023
|
Finished benchmarking commit (2034b6d): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 656.939s -> 655.48s (-0.22%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
builtin_macros::asmdiagnostics to translatable diagnostics #111032 (Migratebuiltin_macros::asmdiagnostics to translatable diagnostics)offset_ofin AST pretty printing #111037 (Close parentheses foroffset_ofin AST pretty printing)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup