Detect Python-like slicing and suggest how to fix #111133

hkmatsumoto · 2023-05-03T13:50:00Z

rustbot · 2023-05-03T13:50:08Z

(rustbot has picked a reviewer for you, use r? to override)

compiler-errors · 2023-05-03T16:35:44Z

tests/ui/suggestions/range-index-instead-of-colon.stderr

+   |                 ~~
+help: maybe write a path separator here
+   |
+LL |     &[1, 2, 3][1::2];


it would be nice if we could get rid of this suggestion

Sounds fair, enclosing the code that triggers this suggestion with else-block should get the job done

compiler-errors · 2023-05-03T16:36:00Z

compiler/rustc_parse/src/parser/stmt.rs

+                        // if a previous and next token of the current one is
+                        // integer literal (e.g. `1:42`), it's likely a range
+                        // expression for Pythonistas and we can suggest so.
+                        if self.prev_token.is_integer_lit()


can you add a call to self.may_recover() just to be safe?

Noratrieb · 2023-06-06T08:41:06Z

compiler/rustc_parse/src/parser/stmt.rs

-                                "maybe write a path separator here",
-                                "::",
+                                self.token.span,
+                                "you might have meant to make a slice with range index",


the error message is too specific for the help being generic. It's sadly not easy to only trigger this only inside indexing expressions, so we should make the message less specific (while still being useful). Maybe you might have meant a range expression? I think that within the context of indexing, that message should still be useful enough. If you don't think so, you could also add , which can be used for indexing at the end, that should really cover it (but being a little verbose).

other than that, I like that change and would be happy to merge it after you improve the message

That's a good point. As of now that the diagnostic will be triggered in a broader context than indexing, your suggestion feels just right

compiler-errors · 2023-06-22T23:27:50Z

@rustbot author

Dylan-DPC · 2023-08-10T10:44:53Z

@hkmatsumoto any updates on this?

Noratrieb · 2023-08-17T18:16:07Z

r? compiler

Fix rust-lang#108215

hkmatsumoto · 2023-11-27T13:04:16Z

Oops, so sorry for taking long to respond. This was buried under a pile of notifications I got during AFK for exams...

Also addressed merge conflicts upon rebasing.

TaKO8Ki · 2023-11-27T13:27:23Z

@rustbot review

TaKO8Ki · 2023-11-27T15:04:08Z

@bors r+ rollup

bors · 2023-11-27T15:04:11Z

📌 Commit acec70d has been approved by TaKO8Ki

It is now in the queue for this repository.

… r=TaKO8Ki Detect Python-like slicing and suggest how to fix Fix rust-lang#108215

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#111133 (Detect Python-like slicing and suggest how to fix) - rust-lang#114708 (Allow setting `rla` labels via `rustbot`) - rust-lang#117526 (Account for `!` arm in tail `match` expr) - rust-lang#118282 (effects: Run `enforce_context_effects` for all method calls) - rust-lang#118366 (Detect and reject malformed `repr(Rust)` hints) - rust-lang#118375 (Add -Zunpretty=stable-mir output test) r? `@ghost` `@rustbot` modify labels: rollup

… r=TaKO8Ki Detect Python-like slicing and suggest how to fix Fix rust-lang#108215

…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#111133 (Detect Python-like slicing and suggest how to fix) - rust-lang#114708 (Allow setting `rla` labels via `rustbot`) - rust-lang#117526 (Account for `!` arm in tail `match` expr) - rust-lang#118341 (Simplify indenting in THIR printing) - rust-lang#118366 (Detect and reject malformed `repr(Rust)` hints) - rust-lang#118375 (Add -Zunpretty=stable-mir output test) - rust-lang#118381 (rustc_span: Use correct edit distance start length for suggestions) - rust-lang#118384 (Address unused tuple struct fields in rustdoc) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#111133 (Detect Python-like slicing and suggest how to fix) - rust-lang#114708 (Allow setting `rla` labels via `rustbot`) - rust-lang#117526 (Account for `!` arm in tail `match` expr) - rust-lang#118172 (Add `pretty_terminator` to pretty stable-mir) - rust-lang#118202 (Added linker_arg(s) Linker trait methods for link-arg to be prefixed "-Wl," for cc-like linker args and not verbatim) - rust-lang#118374 (QueryContext: rename try_collect_active_jobs -> collect_active_jobs, change return type from Option<QueryMap> to QueryMap) - rust-lang#118381 (rustc_span: Use correct edit distance start length for suggestions) - rust-lang#118382 (Address unused tuple struct fields in the compiler) - rust-lang#118384 (Address unused tuple struct fields in rustdoc) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#111133 - hkmatsumoto:handle-python-slicing, r=TaKO8Ki Detect Python-like slicing and suggest how to fix Fix rust-lang#108215

rustbot assigned wesleywiser May 3, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 3, 2023

compiler-errors reviewed May 3, 2023

View reviewed changes

wesleywiser added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2023

hkmatsumoto force-pushed the handle-python-slicing branch from 0c14387 to b8e582e Compare May 16, 2023 06:07

hkmatsumoto added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 16, 2023

Noratrieb reviewed Jun 6, 2023

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2023

compiler-errors assigned Noratrieb and unassigned wesleywiser Jun 22, 2023

rustbot assigned TaKO8Ki and unassigned Noratrieb Aug 17, 2023

hkmatsumoto added 2 commits November 27, 2023 21:48

Detect Python-like slicing and suggest how to fix

e65c060

Fix rust-lang#108215

Make tidy test happy

61c3e4d

Address review feedbacks

730d299

Also addressed merge conflicts upon rebasing.

hkmatsumoto force-pushed the handle-python-slicing branch from b8e582e to 730d299 Compare November 27, 2023 13:07

Change help message to make some sense in broader context

acec70d

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 27, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2023

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 27, 2023

Rollup merge of rust-lang#111133 - hkmatsumoto:handle-python-slicing,…

8d0f7a7

… r=TaKO8Ki Detect Python-like slicing and suggest how to fix Fix rust-lang#108215

matthiaskrgr mentioned this pull request Nov 27, 2023

Rollup of 6 pull requests #118380

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 27, 2023

Rollup merge of rust-lang#111133 - hkmatsumoto:handle-python-slicing,…

11600ff

… r=TaKO8Ki Detect Python-like slicing and suggest how to fix Fix rust-lang#108215

GuillaumeGomez mentioned this pull request Nov 27, 2023

Rollup of 8 pull requests #118387

Closed

compiler-errors mentioned this pull request Nov 28, 2023

Rollup of 9 pull requests #118395

Merged

bors merged commit 203aaf6 into rust-lang:master Nov 28, 2023
11 checks passed

rustbot added this to the 1.76.0 milestone Nov 28, 2023

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2023

Unrolled build for rust-lang#111133

88b340b

Rollup merge of rust-lang#111133 - hkmatsumoto:handle-python-slicing, r=TaKO8Ki Detect Python-like slicing and suggest how to fix Fix rust-lang#108215

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect Python-like slicing and suggest how to fix #111133

Detect Python-like slicing and suggest how to fix #111133

hkmatsumoto commented May 3, 2023

rustbot commented May 3, 2023

compiler-errors May 3, 2023

hkmatsumoto May 16, 2023

compiler-errors May 3, 2023

Noratrieb Jun 6, 2023 •

edited

Loading

hkmatsumoto Nov 27, 2023

compiler-errors commented Jun 22, 2023

Dylan-DPC commented Aug 10, 2023

Noratrieb commented Aug 17, 2023

hkmatsumoto commented Nov 27, 2023

TaKO8Ki commented Nov 27, 2023

TaKO8Ki commented Nov 27, 2023

bors commented Nov 27, 2023

Detect Python-like slicing and suggest how to fix #111133

Detect Python-like slicing and suggest how to fix #111133

Conversation

hkmatsumoto commented May 3, 2023

rustbot commented May 3, 2023

compiler-errors May 3, 2023

Choose a reason for hiding this comment

hkmatsumoto May 16, 2023

Choose a reason for hiding this comment

compiler-errors May 3, 2023

Choose a reason for hiding this comment

Noratrieb Jun 6, 2023 • edited Loading

Choose a reason for hiding this comment

hkmatsumoto Nov 27, 2023

Choose a reason for hiding this comment

compiler-errors commented Jun 22, 2023

Dylan-DPC commented Aug 10, 2023

Noratrieb commented Aug 17, 2023

hkmatsumoto commented Nov 27, 2023

TaKO8Ki commented Nov 27, 2023

TaKO8Ki commented Nov 27, 2023

bors commented Nov 27, 2023

Noratrieb Jun 6, 2023 •

edited

Loading