-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #111638
Rollup of 10 pull requests #111638
Commits on May 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7c1bc03 - Browse repository at this point
Copy the full SHA 7c1bc03View commit details
Commits on May 14, 2023
-
Document that
missing_copy_implementations
and `missing_debug_imple……mentations` only apply to public items.
Configuration menu - View commit details
-
Copy full SHA for 980b392 - Browse repository at this point
Copy the full SHA 980b392View commit details
Commits on May 15, 2023
-
Suppress "erroneous constant used" for constants tainted by errors
When constant evaluation fails because its MIR is tainted by errors, suppress note indicating that erroneous constant was used, since those errors have to be fixed regardless of the constant being used or not.
Configuration menu - View commit details
-
Copy full SHA for 67f455a - Browse repository at this point
Copy the full SHA 67f455aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9799fb1 - Browse repository at this point
Copy the full SHA 9799fb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29a81f5 - Browse repository at this point
Copy the full SHA 29a81f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5763ff - Browse repository at this point
Copy the full SHA a5763ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9688a6c - Browse repository at this point
Copy the full SHA 9688a6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65f9603 - Browse repository at this point
Copy the full SHA 65f9603View commit details -
Add eholk back to compiler-contributors reviewers
@eholk is back from vacation so he can review things again.
Configuration menu - View commit details
-
Copy full SHA for c11fd92 - Browse repository at this point
Copy the full SHA c11fd92View commit details -
Configuration menu - View commit details
-
Copy full SHA for eeeb70e - Browse repository at this point
Copy the full SHA eeeb70eView commit details
Commits on May 16, 2023
-
Rollup merge of rust-lang#111428 - bvanjoi:fix-109250, r=Nilstrieb
refactor(resolve): clean up the early error return caused by non-call closes rust-lang#109250 It seems no bad happened, r? `@Nilstrieb`
Configuration menu - View commit details
-
Copy full SHA for a776f90 - Browse repository at this point
Copy the full SHA a776f90View commit details -
Rollup merge of rust-lang#111449 - compiler-errors:recover-impl-gener…
…ics-correctly, r=Nilstrieb Recover `impl<T ?Sized>` correctly Fixes rust-lang#111327 r? ```@Nilstrieb``` but you can re-roll Alternatively, happy to close this if we're okay with just saying "sorry rust-lang#111327 is just a poor side-effect of parser ambiguity" 🤷
Configuration menu - View commit details
-
Copy full SHA for dd55ea9 - Browse repository at this point
Copy the full SHA dd55ea9View commit details -
Rollup merge of rust-lang#111572 - kpreid:mdi, r=compiler-errors
Document that `missing_copy_implementations` and `missing_debug_implementations` only apply to public items. I encountered rust-lang#111359 (fixed) and noticed that the documentation didn't say that it was _intended_ that `missing_debug_implementations` only applies to public items. This PR fixes that, and makes the same wording change to `missing_copy_implementations` which has the same condition. I chose the words to also be similar to `missing_docs` which already had such a remark.
Configuration menu - View commit details
-
Copy full SHA for e620b29 - Browse repository at this point
Copy the full SHA e620b29View commit details -
Rollup merge of rust-lang#111602 - tmiasko:erroneous-constant-used, r…
…=oli-obk Suppress "erroneous constant used" for constants tainted by errors When constant evaluation fails because its MIR is tainted by errors, suppress note indicating that erroneous constant was used, since those errors have to be fixed regardless of the constant being used or not. Fixes rust-lang#110891.
Configuration menu - View commit details
-
Copy full SHA for 0ae644d - Browse repository at this point
Copy the full SHA 0ae644dView commit details -
Rollup merge of rust-lang#111605 - klensy:fixup_version, r=compiler-e…
…rrors fixup version placeholder for `cfi_encoding` feature Mentioned rust-lang#105452 (comment)
Configuration menu - View commit details
-
Copy full SHA for 2573483 - Browse repository at this point
Copy the full SHA 2573483View commit details -
Rollup merge of rust-lang#111607 - jyn514:clubby-reviews, r=clubby789
Add clubby789 to the bootstrap review rotation r? ````@clubby789```` - thank you for volunteering! I have been meaning for a very long time now to write up how to do reviews, but I haven't gotten around to it yet :( here is a short summary: 1. If you're not sure what the changes does or if it's ok, always feel free to ping someone else on the team, especially in the first few weeks. You can use `r? bootstrap` to get triagebot to assign someone else. 2. Bootstrap unfortunately has very few tests. Things that touch CLI or toml parsing should likely have a test in `src/bootstrap/config/tests.rs`; things that touch "core" build logic should have a test in `builder/tests.rs`, anything else kinda just slips in :( see rust-lang#102563 for ideas on how to improve the situation here. 3. "Major" changes should be documented in `src/bootstrap/CHANGELOG.md`. "Major" is up to you, but if it breaks a config option or otherwise is likely to break *someone's* build, it's probably major. If it breaks nearly *everyone*'s build, it should also update `VERSION` in `lib.rs`; this should be very rare. Please also ping me or Mark-Simulacrum for major changes (I might set up a triagebot ping for this so you don't have to remember). 4. Once you've approved the PR, tell bors it's ok - you've been contributing for a while so you know how bors works, but here's a cheatsheet just in case: https://bors.rust-lang.org Documentation about how to use bootstrap lives at https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html; internal docs live in `src/bootstrap/README.md`. The latter unfortunately is not very complete.
Configuration menu - View commit details
-
Copy full SHA for bbbc728 - Browse repository at this point
Copy the full SHA bbbc728View commit details -
Rollup merge of rust-lang#111614 - aDotInTheVoid:nonsense, r=cjgillot
Add more interesting nonsense to weird-exprs.rs Some cursed things rust allows that I've ran into. [The second is taken from here](https://twitter.com/Lucretiel/status/1638929955751964679)
Configuration menu - View commit details
-
Copy full SHA for e973cc7 - Browse repository at this point
Copy the full SHA e973cc7View commit details -
Rollup merge of rust-lang#111617 - kesleta:master, r=Dylan-DPC
Fixed typo Fixed typo in BTree Curser.
Configuration menu - View commit details
-
Copy full SHA for 6e1cc3e - Browse repository at this point
Copy the full SHA 6e1cc3eView commit details -
Rollup merge of rust-lang#111620 - eholk:eholk-back-from-vacation, r=…
…wesleywiser Add eholk back to compiler-contributors reviewers ``@eholk`` is back from vacation so he can review things again. r? ``@wesleywiser``
Configuration menu - View commit details
-
Copy full SHA for 1a4e749 - Browse repository at this point
Copy the full SHA 1a4e749View commit details -
Rollup merge of rust-lang#111621 - ehuss:relnotes-1.58.1-date, r=Mark…
…-Simulacrum Fix release date of 1.58.1 in release notes. This fixes the release notes to have the correct release date for 1.58.1. The [blog announcement](https://blog.rust-lang.org/2022/01/20/Rust-1.58.1.html) has the correct date and link (which is otherwise broken without this change). Closes rust-lang#94278
Configuration menu - View commit details
-
Copy full SHA for 74b6395 - Browse repository at this point
Copy the full SHA 74b6395View commit details